From owner-freebsd-hackers Tue Sep 5 06:33:39 1995 Return-Path: hackers-owner Received: (from majordom@localhost) by freefall.freebsd.org (8.6.11/8.6.6) id GAA23197 for hackers-outgoing; Tue, 5 Sep 1995 06:33:39 -0700 Received: from chrome.onramp.net (chrome.onramp.net [199.1.166.202]) by freefall.freebsd.org (8.6.11/8.6.6) with ESMTP id GAA23183 for ; Tue, 5 Sep 1995 06:33:37 -0700 Received: from localhost.jdl.com (localhost.jdl.com [127.0.0.1]) by chrome.onramp.net (8.6.11/8.6.9) with SMTP id IAA19701; Tue, 5 Sep 1995 08:31:55 -0500 Message-Id: <199509051331.IAA19701@chrome.onramp.net> X-Authentication-Warning: chrome.onramp.net: Host localhost.jdl.com didn't use HELO protocol To: Bruce Evans cc: vak@cronyx.ru, hackers@freebsd.org Subject: Re: Help installing IDE CD-ROM driver In-reply-to: Your message of "Tue, 05 Sep 1995 20:33:54 +1000." <199509051033.UAA02568@godzilla.zeta.org.au> Reply-To: jdl@chromatic.com Clarity-Index: null Threat-Level: none Software-Engineering-Dead-Seriousness: There's no excuse for unreadable code. Net-thought: If you meet the Buddha on the net, put him in your Kill file. Date: Tue, 05 Sep 1995 08:31:54 -0500 From: Jon Loeliger Sender: hackers-owner@freebsd.org Precedence: bulk Apparently, Bruce Evans scribbled: > wcd actually sort of supports 2^30 partitions, all the same (because > wcdopen() doesn't check the top 30 bits in the device number :-(). > There would be aliasing problems if someone created one of the other > minors and used both. There are aliasing problems now between the cdev > and the bdev. E.g., opening the cdev while the bdev is open invalidates > the F_OPEN flag and messes up media change stuff. The `fmt' arg to > wdopen() and wdclose() that is required to distinguish cdevs from bdevs > is missing. dsopen() and dsclose() handle all these aliasing problems. I have also modified wcd.c's wcdattach() to return the obvious -1 or 0 upon failure or success respectively. Seems reasonable to me given atapi.c expects to use the return code that way too... jdl