From owner-svn-src-head@freebsd.org Sat Oct 21 08:10:39 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ABB42E50AB3; Sat, 21 Oct 2017 08:10:39 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-pg0-f48.google.com (mail-pg0-f48.google.com [74.125.83.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 836B177DDA; Sat, 21 Oct 2017 08:10:39 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-pg0-f48.google.com with SMTP id m18so8282873pgd.13; Sat, 21 Oct 2017 01:10:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RYpPPACEXlbN9IgHNQ+wEfSym4htlSkDJq/Go05HliU=; b=MNKIXnRoxeTn0+BWqNUQORC4XGfN0/FuyxDrNkCHp+K6J6F5rk9MLWN2v8PU1WDuh0 IK8AMwAM+XjxbhmD7+1GqTwKzsXwE6E9nRDONCTNr7omR4t/0M/Z0W/FBTnfLFv1JahB WoYW+cdGY9nZyht0cWHw9lNX6K3kYc2kpxCeqrYWLZZBHPWNKMeS4qvf6tUCaqtbP0Fz vuF2MQBbp3MSnaxEJHWDhpKhZeBi+gJkxp0obwIiycfeI0YmlnpxSxfAjvFS5Al1ZMYh esNozpXLe3HFDPGAxrbeu76q+rg7l8B/yGbe6btNEpHaHADB7Uz9+5PcJAirUPfqIDZh SbcA== X-Gm-Message-State: AMCzsaV2TH+V6otYC1gUk0nSKw+qy5WWDZwujzHhgoBRoPz+MdL4ixZT rQ9zji+VpGE7jejFT3muUpgbTB0Yl/s= X-Received: by 10.98.133.28 with SMTP id u28mr7392361pfd.241.1508573432753; Sat, 21 Oct 2017 01:10:32 -0700 (PDT) Received: from mail-pg0-f52.google.com (mail-pg0-f52.google.com. [74.125.83.52]) by smtp.gmail.com with ESMTPSA id f6sm3760806pgo.11.2017.10.21.01.10.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Oct 2017 01:10:32 -0700 (PDT) Received: by mail-pg0-f52.google.com with SMTP id s2so8280803pge.10; Sat, 21 Oct 2017 01:10:32 -0700 (PDT) X-Google-Smtp-Source: ABhQp+TtPj6yBBX1VwgSkmhUXNXXGWwYeGqELdOX8e4CbLmcSEL3eh+b0Mg6zu4Hd7+OKEHMX4m68s5VAGlioANBjpE= X-Received: by 10.98.51.198 with SMTP id z189mr7246558pfz.198.1508573431729; Sat, 21 Oct 2017 01:10:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.180.131 with HTTP; Sat, 21 Oct 2017 01:10:31 -0700 (PDT) In-Reply-To: <401F7CFC-1381-4F60-92DE-5771566CD992@gmail.com> References: <201710210723.v9L7Nj6W016491@repo.freebsd.org> <401F7CFC-1381-4F60-92DE-5771566CD992@gmail.com> From: Ryan Libby Date: Sat, 21 Oct 2017 01:10:31 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r324811 - in head/sys/dev/pms/freebsd/driver: common ini/src To: "Ngie Cooper (yaneurabeya)" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Pedro Giffuni , benno@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Oct 2017 08:10:39 -0000 On Sat, Oct 21, 2017 at 12:43 AM, Ngie Cooper (yaneurabeya) wrote: > >> On Oct 21, 2017, at 00:23, Ryan Libby wrote: >> >> Author: rlibby >> Date: Sat Oct 21 07:23:45 2017 >> New Revision: 324811 >> URL: https://svnweb.freebsd.org/changeset/base/324811 >> >> Log: >> pms/freebsd: fix compiler warnings >> >> - A number of unused variable warnings, >> - a missing prototype warning (actually a dead function), >> - and a potential use of an uninitialized variable. > > You probably should look for the other _fantastic_ fixes that Danny Ryan = cooked up for the driver. I don=E2=80=99t think you=E2=80=99ve found the br= anches that result in logic errors which trigger corruption yet=E2=80=A6 > Cheers, > -Ngie Thanks, I will ping him. Yes, this is just from clang and gcc warnings and of that just for what's under sys/dev/pms/freebsd. I also have patches for fixes for warnings across sys/dev/pms, and pfg has a spelling fixup patch. There seems to be a little uncertainty about how to proceed wrt maintenance of the driver, so I won't be pushing those changes until that is clarified. (Is freebsd the de facto upstream now?)