From owner-freebsd-fs@FreeBSD.ORG Mon Nov 15 03:20:05 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5CD2C106564A for ; Mon, 15 Nov 2010 03:20:05 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 03E9F8FC17 for ; Mon, 15 Nov 2010 03:19:58 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id B6F5945CD8; Mon, 15 Nov 2010 04:19:56 +0100 (CET) Received: from localhost (chello089073192049.chello.pl [89.73.192.49]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id C92B945683; Mon, 15 Nov 2010 04:19:51 +0100 (CET) Date: Mon, 15 Nov 2010 04:19:04 +0100 From: Pawel Jakub Dawidek To: Mikolaj Golub Message-ID: <20101115031904.GJ4780@garage.freebsd.pl> References: <86wrogqn8d.fsf@kopusha.home.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/0P/MvzTfyTu5j9Q" Content-Disposition: inline In-Reply-To: <86wrogqn8d.fsf@kopusha.home.net> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: freebsd-fs@freebsd.org Subject: Re: hastd/primary.c micro fixes X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2010 03:20:05 -0000 --/0P/MvzTfyTu5j9Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 14, 2010 at 11:16:18AM +0200, Mikolaj Golub wrote: > Hi, >=20 > noticed the following in hastd/primary.c: >=20 > 1) in init_remote() when incoming connection is set up, if proto_client() > fails it only reports about the error and try proto_connect() anyway. This > will cause a crash as proto_conn structure is not valid. Primary should r= ather > exit (as it is when outgoing connection is set up, and as it is in the pa= tch > below) or set proto_conn pointer to NULL and goto close. >=20 > 2) in guard_thread() timeout.tv_sec is set in loop, while it looks like i= t may > be set only once before the loop. Thanks, I committed both changes. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --/0P/MvzTfyTu5j9Q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkzgpqcACgkQForvXbEpPzQ4xwCfUdeVz3dOii6sW71zcXxXqhCV ZtYAn1xp+0jAHy2I5hKgh+lAba8DUGX/ =zP4z -----END PGP SIGNATURE----- --/0P/MvzTfyTu5j9Q--