Date: Thu, 29 Nov 2012 08:23:45 +0100 From: Andre Oppermann <andre@freebsd.org> To: Vijay Singh <vijju.singh@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, "Robert N. M. Watson" <rwatson@freebsd.org>, Peter Wemm <peter@wemm.org> Subject: Re: svn commit: r243627 - head/sys/kern Message-ID: <50B70D81.5090000@freebsd.org> In-Reply-To: <CALCNsJT_my7NRCzOyP3f=soQW4aM1jt%2Bb5=%2BABeCpVFFenrVBQ@mail.gmail.com> References: <201211272004.qARK4qS8047209@svn.freebsd.org> <CAGE5yCpxOdsjefe6quR_gjs82pk9a2e_H_WUNUWhUGA3WZPJaw@mail.gmail.com> <50B54180.5020608@freebsd.org> <alpine.BSF.2.00.1211272246560.37292@fledge.watson.org> <50B54492.5040100@freebsd.org> <956CE44A-BA0F-4FE4-AA38-F4B90C85ECBA@FreeBSD.org> <50B54CE0.6080008@freebsd.org> <2A12C740-1D72-4D30-B663-47A37AAC2FF3@FreeBSD.org> <50B5C4F1.1020002@freebsd.org> <CALCNsJT_my7NRCzOyP3f=soQW4aM1jt%2Bb5=%2BABeCpVFFenrVBQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29.11.2012 01:35, Vijay Singh wrote: >> a sign of poor prior testing and too much trust into the submitter of >> the patch it wasn't an earth shattering event. Doesn't distract from > > Andre, I am really quite disappointed to read this from you. The patch > I sent you was fine, and has been well tested here. You modified it > and made the error. If you wish, I can attach the mail I sent with the > patch. Vijay, Your original patch indeed was correct wrt. testing against the head pointer. On Nov. 2 I sent you my (wrongly) modified patch for review and testing. On Nov. 5 you replied that is looks good to you. There is no doubt that I screwed up about everything else on this patch but I did send it for review and you didn't catch the mistake I made. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50B70D81.5090000>