From owner-cvs-all@FreeBSD.ORG Wed Nov 3 19:20:24 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 605E416A4E0; Wed, 3 Nov 2004 19:20:24 +0000 (GMT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4F5743D5C; Wed, 3 Nov 2004 19:20:23 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.10.171.95] (mail.atheros.com [65.212.155.130]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id iA3JKEWi030113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Nov 2004 11:20:20 -0800 (PST) (envelope-from sam@errno.com) Message-ID: <41892F68.9080603@errno.com> Date: Wed, 03 Nov 2004 11:20:08 -0800 From: Sam Leffler Organization: Errno Consulting User-Agent: Mozilla Thunderbird 0.8 (Macintosh/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Scott Long References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> <20041103082806.C49241@xorpc.icir.org> <41890956.2030705@freebsd.org> In-Reply-To: <41890956.2030705@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-vtss-Metrics: ebb.errno.com 1018; Body=6 Fuz1=6 Fuz2=6 cc: Luigi Rizzo cc: src-committers@FreeBSD.org cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 19:20:24 -0000 Scott Long wrote: > Luigi Rizzo wrote: > >> On Wed, Nov 03, 2004 at 09:23:01AM -0700, Scott Long wrote: >> ... >> >>> I think that in general we can start eyeing a lot of similar verbosity >>> in all of our drivers, both at boot and at runtime. For example most >>> nic drivers print out their MAC and all of their possible negotiation >>> rates on attach. This same info can be obtained from ifconfig. Why >>> clutter the boot with it? >> >> >> >> because sometimes you might need to enable some MAC-based filter >> before you have a chance to access the box. e.g. to set dhcp/bootp >> anbd the like. >> >> A bit of verbosity is useful, you can always switch to splash screens >> if you don't like them. >> >> I think the link-up/link-down thing is different because it >> happens not just at boot but also whenever the link status >> changes (e.g. when a spanning tree on a switch detects a >> reconfiguration), and this is annoying on the console. >> >> cheers >> luigi >> > > I'm not saying that these things should be removed, just places under > bootverbose. Situations like what you are saying are rare and/or > one-time occurances. And if you look at drivers like if_ath(no offense > meant towards Sam): > > ath0: mem 0xf4010000-0xf401ffff irq 11 at device 0.0 on > cardbus1 > ath0: mac 5.6 phy 4.1 5ghz radio 1.7 2ghz radio 2.3 > ath0: Ethernet address: 00:0c:41:15:5f:94 > ath0: 11a rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps > ath0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps > ath0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18Mbps > 24Mbps 36Mbps 48Mbps 54Mbps > ath0: turbo rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps > > The last 4 lines could easily go under bootverbose. I'd even wager that > the second line can be hidden also; it provides little useful > information for a normal boot. The 2nd line cannot be removed. I'm ok with moving the rates under bootverbose. Sam