From owner-svn-src-all@FreeBSD.ORG Tue Jan 13 21:30:09 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A92571065670; Tue, 13 Jan 2009 21:30:09 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from semihalf.com (semihalf.com [206.130.101.55]) by mx1.freebsd.org (Postfix) with ESMTP id 609A78FC08; Tue, 13 Jan 2009 21:30:09 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from mail.semihalf.com (mail.semihalf.com [83.15.139.206]) by semihalf.com (8.13.1/8.13.1) with ESMTP id n0DKvZiD023976; Tue, 13 Jan 2009 13:57:37 -0700 Received: from [95.41.73.8] (apn-95-41-73-8.gprs.plus.pl [95.41.73.8]) by mail.semihalf.com (Postfix) with ESMTP id 654FA151DC; Tue, 13 Jan 2009 22:17:55 +0100 (CET) Message-ID: <496D0028.7080302@semihalf.com> Date: Tue, 13 Jan 2009 21:57:12 +0100 From: Rafal Jaworowski Organization: Semihalf MIME-Version: 1.0 To: Alan Cox References: <200901131615.n0DGFnuC008182@svn.freebsd.org> <496CE1D6.6000101@cs.rice.edu> In-Reply-To: <496CE1D6.6000101@cs.rice.edu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187151 - head/sys/powerpc/booke X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jan 2009 21:30:10 -0000 Alan Cox wrote: > Both the BookE and MIPS pmap modules need to have their get_pv_entry() > functions updated. Their implementations of get_pv_entry() look like > what I would expect to find in FreeBSD 4. For example, the modern > equivalent of pmap_collect() is performed synchronously from > get_pv_entry() rather than asynchronously as a side-effect of waking the > page daemon. As a result of this mismatch, there is no > pmap_collect()-like support in HEAD for either BookE or MIPS. This > could cause either to crash under memory pressure. > > The simplest correct implementation of get_pv_entry() can be found in > the IA64 pmap module. You could cut-and-paste all but the body of the > inner loop. (amd64 and i386 are complicated by their efforts to save > memory.) Alan, Thanks for bringing it out and the hints. I'll take a look and try to improve this for the BookE. Rafal