From owner-cvs-all@FreeBSD.ORG Tue Jan 17 17:08:54 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 09E0916A41F; Tue, 17 Jan 2006 17:08:54 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 28DC243D46; Tue, 17 Jan 2006 17:08:51 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 6278747 for multiple; Tue, 17 Jan 2006 12:07:28 -0500 Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k0HH8oif038993; Tue, 17 Jan 2006 12:08:50 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Maxime Henrion Date: Tue, 17 Jan 2006 12:02:02 -0500 User-Agent: KMail/1.9.1 References: <200512202106.jBKL6hNr035186@repoman.freebsd.org> <20060117163014.GA17831@FreeBSD.org> <20060117164700.GN55746@elvis.mu.org> In-Reply-To: <20060117164700.GN55746@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200601171202.05810.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1244/Tue Jan 17 03:46:07 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.4 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, Alexey Dokuchaev , src-committers@freebsd.org, Doug Rabson , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/pci agp.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2006 17:08:54 -0000 On Tuesday 17 January 2006 11:47, Maxime Henrion wrote: > Alexey Dokuchaev wrote: > > On Tue, Jan 17, 2006 at 04:19:07PM +0000, Doug Rabson wrote: > > > On 17 Jan 2006, at 16:11, John Baldwin wrote: > > > >On Tuesday 17 January 2006 06:51, Doug Rabson wrote: > > > >>On 20 Dec 2005, at 21:06, John Baldwin wrote: > > > >>>jhb 2005-12-20 21:06:43 UTC > > > >>> > > > >>> FreeBSD src repository > > > >>> > > > >>> Modified files: > > > >>> sys/pci agp.c > > > >>> Log: > > > >>> Change the agp_find_device() to return the first agp device that > > > >>>has been > > > >>> attached to a driver rather than always returning agp0. > > > >> > > > >>According to Coverity, this introduces a memory leak > > > >>(devclass_get_devices() allocates memory). > > > > > > > >That it does. How about this fix: > > > > > > Looks good to me. > > > > Except for style bugs (parens around return value). > > It rather looks like John has followed the existing style in this file, > which is perfectly legitimate. Yeah, the missing ()'s were intentional to maintain consistency. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org