From owner-freebsd-current@FreeBSD.ORG Wed Mar 25 09:25:17 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 56756106566C for ; Wed, 25 Mar 2009 09:25:17 +0000 (UTC) (envelope-from gperez@entel.upc.edu) Received: from dash.upc.es (dash.upc.es [147.83.2.50]) by mx1.freebsd.org (Postfix) with ESMTP id D28CD8FC19 for ; Wed, 25 Mar 2009 09:25:16 +0000 (UTC) (envelope-from gperez@entel.upc.edu) Received: from hamilton.upcnetadm.upcnet.es (hamilton.upcnetadm.upcnet.es [147.83.2.240]) by dash.upc.es (8.14.1/8.13.1) with ESMTP id n2P9PEBh009816 for ; Wed, 25 Mar 2009 10:25:15 +0100 Received: from [147.83.40.234] ([147.83.40.234]) by hamilton.upcnetadm.upcnet.es (Lotus Domino Release 5.0.12) with ESMTP id 2009032510251404:182981 ; Wed, 25 Mar 2009 10:25:14 +0100 Message-ID: <49C9F7F6.2000908@entel.upc.edu> Date: Wed, 25 Mar 2009 10:23:02 +0100 From: Gustau Perez User-Agent: Thunderbird 2.0.0.21 (X11/20090323) MIME-Version: 1.0 To: freebsd-current@freebsd.org References: <49C80DBA.80407@entel.upc.edu> <20090325033451.GA17442@zim.MIT.EDU> In-Reply-To: <20090325033451.GA17442@zim.MIT.EDU> X-MIMETrack: Itemize by SMTP Server on hamilton/UPC(Release 5.0.12 |February 13, 2003) at 25/03/2009 10:25:14, Serialize by Router on hamilton/UPC(Release 5.0.12 |February 13, 2003) at 25/03/2009 10:25:15, Serialize complete at 25/03/2009 10:25:15 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Mail-Scanned: Criba 2.0 + Clamd X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (dash.upc.es [147.83.2.50]); Wed, 25 Mar 2009 10:25:15 +0100 (CET) Subject: Re: Inline definition problem in current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2009 09:25:17 -0000 >> >> Checking pontyhat shows me that many ports are failing because of >> this problem. What I can understand is why is this happening, because >> the same ports compiles fine in STABLE and the compilers's version in >> base seems to be the same (gcc (GCC) 4.2.1 20070719 [FreeBSD], the same >> in current) >> > > Which other ports were broken for this reason? > Well, I remember compiling all gnome (and dependences) in a row. I remember failing audio/faad, net-im/telepathy-mission-control, but I think others failed. I've just tried changing inline declarations to extern inline [return type/void] __attribute__((gnu_inline)) with a port that was failing (compiz-fusion-plugins-main) as I suggested previously and is compiling fine both in STABLE and in CURRENT. In the other hand, audio/faad in CURRENT compiles fine changing "INLINE void cfftf1" to "extern INLINE void cfft1 __attribute__((gnu_inline)) in libfaad/cfft.c around line 60 (please check one of my previous posts for details). In the case of faad, the function is never implemented :) but the other packages affected they implement the offending function/procedure. So instead of hacking gcc reverting the changes made to it in current, I think it would be wise to change the affected ports, as them will compile in both worlds. I can send PR's requesting the change for audio/faad net-im/telepathy-mission-control and x11-wm/compiz-fusion-plugins-main Greets, Gus