From owner-svn-src-all@FreeBSD.ORG  Sun Nov 18 15:46:15 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id AB634918;
 Sun, 18 Nov 2012 15:46:15 +0000 (UTC) (envelope-from uqs@FreeBSD.org)
Received: from acme.spoerlein.net (acme.spoerlein.net
 [IPv6:2a01:4f8:131:23c2::1])
 by mx1.freebsd.org (Postfix) with ESMTP id 334E38FC17;
 Sun, 18 Nov 2012 15:46:15 +0000 (UTC)
Received: from localhost (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1])
 by acme.spoerlein.net (8.14.5/8.14.5) with ESMTP id qAIFkDth089018
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);
 Sun, 18 Nov 2012 16:46:13 +0100 (CET) (envelope-from uqs@FreeBSD.org)
Date: Sun, 18 Nov 2012 16:46:10 +0100
From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@FreeBSD.org>
To: Eitan Adler <eadler@FreeBSD.org>
Subject: Re: svn commit: r243130 - head/etc/root
Message-ID: <20121118154610.GC28199@acme.spoerlein.net>
Mail-Followup-To: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@FreeBSD.org>,
 Eitan Adler <eadler@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201211160425.qAG4PZ8I016575@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201211160425.qAG4PZ8I016575@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Nov 2012 15:46:15 -0000

On Fri, 2012-11-16 at 04:25:35 +0000, Eitan Adler wrote:
> Author: eadler
> Date: Fri Nov 16 04:25:35 2012
> New Revision: 243130
> URL: http://svnweb.freebsd.org/changeset/base/243130
> 
> Log:
>   dot.login is supposed to be for bourne shell, not csh
>   
>   Pointyhat to: me
>   Approved by: cperciva (implicit)
> 
> Modified:
>   head/etc/root/dot.login
> 
> Modified: head/etc/root/dot.login
> ==============================================================================
> --- head/etc/root/dot.login	Fri Nov 16 03:33:34 2012	(r243129)
> +++ head/etc/root/dot.login	Fri Nov 16 04:25:35 2012	(r243130)
> @@ -6,4 +6,4 @@
>  #
>  
>  # Uncomment to display a random cookie each login:
> -# if ( -x /usr/games/fortune ) /usr/games/fortune -s
> +# [ -x /usr/games/fortune ] && /usr/games/fortune -s

Please add || true to that line, so that when it is enabled and
/usr/games/fortune doesn't exist or is not executable, the shell startup
doesn't return with $? set to something non-zero.

This is especially annoying if you have $? somewhere in your prompt.

Thanks
Uli