From owner-svn-src-all@FreeBSD.ORG Wed Oct 23 00:34:52 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 99661639; Wed, 23 Oct 2013 00:34:52 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6C3322452; Wed, 23 Oct 2013 00:34:52 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1VYmPM-0001an-PS; Wed, 23 Oct 2013 00:34:44 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id r9N0YgdH043128; Tue, 22 Oct 2013 18:34:42 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18PWP1Q+FVH4dSbaiuV2lmC Subject: Re: svn commit: r256943 - head/sys/arm/xscale/ixp425 From: Ian Lepore To: Olivier Houchard In-Reply-To: <201310222151.r9MLp7lL066168@svn.freebsd.org> References: <201310222151.r9MLp7lL066168@svn.freebsd.org> Content-Type: text/plain; charset="us-ascii" Date: Tue, 22 Oct 2013 18:34:42 -0600 Message-ID: <1382488482.92499.199.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Oct 2013 00:34:52 -0000 On Tue, 2013-10-22 at 21:51 +0000, Olivier Houchard wrote: > Author: cognet > Date: Tue Oct 22 21:51:07 2013 > New Revision: 256943 > URL: http://svnweb.freebsd.org/changeset/base/256943 > > Log: > - Use bus_dmamap_unload(), it is not optional. > - The new allocator won't return coherent memory for any size > PAGE_SIZE, > so don't assume we have coherent memory, and explicitely use > bus_dmamap_sync(). > > Modified: > head/sys/arm/xscale/ixp425/if_npe.c > [snip] Whoa, not true! If you ask for BUS_DMA_COHERENT memory on arm you are g'teed to get uncached memory. If the size you ask for is under one page it comes from the uma allocator, if you want a page or more it comes from either kmem_alloc_attr() or kmem_alloc_contig() using the VM_MEMATTR_UNCACHEABLE flag, which is handled in arm/pmap[-v6].c by turning off the cache and buffered bits on the pages. -- Ian