From owner-cvs-src@FreeBSD.ORG  Sat Apr  3 14:46:33 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 636E916A4CF
	for <cvs-src@freebsd.org>; Sat,  3 Apr 2004 14:46:33 -0800 (PST)
Received: from root.org (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 0714F43D66
	for <cvs-src@freebsd.org>; Sat,  3 Apr 2004 14:46:33 -0800 (PST)
	(envelope-from nate@root.org)
Received: (qmail 11571 invoked by uid 1000); 3 Apr 2004 22:46:34 -0000
Date: Sat, 3 Apr 2004 14:46:34 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: Alexey Dokuchaev <danfe@nsu.ru>
In-Reply-To: <20040403200844.GA18516@regency.nsu.ru>
Message-ID: <20040403144540.Q11430@root.org>
References: <20040331211028.37B5016A4E2@hub.freebsd.org>
	<20040331134609.N90425@root.org>
	<20040401105857.GA72284@regency.nsu.ru>
	<20040403200844.GA18516@regency.nsu.ru>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: Ruslan Ermilov <ru@freebsd.org>
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/pci if_ste.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Apr 2004 22:46:33 -0000

On Sun, 4 Apr 2004, Alexey Dokuchaev wrote:
> On Thu, Apr 01, 2004 at 04:50:11PM +0300, Ruslan Ermilov wrote:
> > On Thu, Apr 01, 2004 at 05:58:57PM +0700, Alexey Dokuchaev wrote:
> > > On Thu, Apr 01, 2004 at 09:42:41AM +0300, Ruslan Ermilov wrote:
> > > > On Wed, Mar 31, 2004 at 01:47:16PM -0800, Nate Lawson wrote:
> > [...]
> > > > > This pollutes the toplevel hw sysctl space.  Please move it to
> > > > > hw.ste.rxsyncs or better, debug.*.
> > > > >
> > > > Seems I followed the bad practice from dc(4) and fxp(4).  I will
> > > > move it to hw.ste, thanks.
> > >
> > > Care to fix this "bad practice" in dc(4) and fxp(4) as well? :)  Or
> > > should we wait for their maintainers, or possibly filling the PR ?
> > >
> > Better submit a patch, it should be pretty trivial.  ;)
>
> OK, I'll do it in a couple of days, hopefully for both dc(4) and fxp(4).

Thank you.  In general, I only want a PR if the problem is complex or
needs further debugging.  People with simple changes for code I'm active
in should just send a patch.

-Nate