From owner-freebsd-current@FreeBSD.ORG Thu Jul 24 05:00:37 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A27BE37B401; Thu, 24 Jul 2003 05:00:37 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4585343F85; Thu, 24 Jul 2003 05:00:27 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6OC0N0U035264 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 24 Jul 2003 15:00:23 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6OC0MhE035259; Thu, 24 Jul 2003 15:00:22 +0300 (EEST) (envelope-from ru) Date: Thu, 24 Jul 2003 15:00:22 +0300 From: Ruslan Ermilov To: current@FreeBSD.org Message-ID: <20030724120022.GA29015@sunbay.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UlVJffcvxoiEqYs2" Content-Disposition: inline User-Agent: Mutt/1.5.4i cc: Mark Murray Subject: NOCRYPT and exists(src/crypto) check X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 12:00:38 -0000 --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi there! There's currently an inconsistency in how various makefiles (that use crypto bits) check if these bits are available. All of them check for the NOCRYPT knob, and some of them also check if src/crypto/ exists, and some not. None of them also check if src/secure/ exists, which is the where the crypto libraries get actually built. Here's the current summary of these makefiles: makefiles that don't check if src/crypto/ exists: gnu/usr.bin/cvs/cvs/Makefile lib/libfetch/Makefile lib/libtelnet/Makefile libexec/telnetd/Makefile usr.bin/fetch/Makefile usr.bin/telnet/Makefile usr.sbin/pkg_install/Makefile usr.sbin/pkg_install/add/Makefile usr.sbin/pkg_install/create/Makefile usr.sbin/pkg_install/delete/Makefile usr.sbin/pkg_install/info/Makefile usr.sbin/pkg_install/version/Makefile makefiles that check if src/crypto/ exists: bin/ed/Makefile games/factor/Makefile lib/Makefile rescue/rescue/Makefile usr.bin/Makefile usr.sbin/Makefile usr.sbin/ppp/Makefile usr.sbin/pppd/Makefile usr.sbin/sendmail/Makefile usr.sbin/tcpdump/tcpdump/Makefile Since the "exists(${.CURDIR}/.../crypto) && !defined(NOCRYPT)" check is weak (it lacks the exists(${.CURDIR}/.../secure) check), I suggest to simplify these makefiles and remove these obscure exists() checks. Users that don't fetch crypto sources (src/crypto/ and src/secure/) will then just have to specify that in their /etc/make.conf. Not fetching crypto sources and not specifying NOCRYPT currently gives a broken build, so this change shouldn't surprise a lot of people. Also, a similar change for src/kerberos5/ is proposed. I'd appreciate a quick response. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --UlVJffcvxoiEqYs2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/H8pWUkv4P6juNwoRAqYnAJ4o946/2wvIxKEaARZUzR9iBMOvcQCfc7tR KVwFL4bO7hZtjLsqpvkxdl8= =27Q8 -----END PGP SIGNATURE----- --UlVJffcvxoiEqYs2--