From owner-svn-src-head@FreeBSD.ORG Sun Oct 5 18:21:15 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7FDFA46D; Sun, 5 Oct 2014 18:21:15 +0000 (UTC) Received: from fep26.mx.upcmail.net (fep26.mx.upcmail.net [62.179.121.46]) by mx1.freebsd.org (Postfix) with ESMTP id F34F8909; Sun, 5 Oct 2014 18:21:13 +0000 (UTC) Received: from edge04.upcmail.net ([192.168.13.239]) by viefep20-int.chello.at (InterMail vM.8.01.05.13 201-2260-151-135-20130320) with ESMTP id <20141005181907.NMJK24820.viefep20-int.chello.at@edge04.upcmail.net>; Sun, 5 Oct 2014 20:19:07 +0200 Received: from mole.fafoe.narf.at ([80.109.238.242]) by edge04.upcmail.net with edge id zWK51o01W5EV2AQ01WK5l9; Sun, 05 Oct 2014 20:19:06 +0200 X-SourceIP: 80.109.238.242 Received: by mole.fafoe.narf.at (Postfix, from userid 1001) id E65436D47C; Sun, 5 Oct 2014 20:19:06 +0200 (CEST) Date: Sun, 5 Oct 2014 20:19:06 +0200 From: Stefan Farfeleder To: Konstantin Belousov Subject: Re: svn commit: r272505 - in head/sys: kern sys Message-ID: <20141005181906.GB1890@mole.fafoe.narf.at> References: <201410040808.s9488uAI099166@svn.freebsd.org> <42180557-0119-4597-9492-662E1671A840@FreeBSD.org> <20141005163953.GA1890@mole.fafoe.narf.at> <20141005171617.GB26076@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141005171617.GB26076@kib.kiev.ua> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: src-committers@freebsd.org, Mateusz Guzik , svn-src-all@freebsd.org, "Bjoern A. Zeeb" , Konstantin Belousov , svn-src-head@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Oct 2014 18:21:15 -0000 On Sun, Oct 05, 2014 at 08:16:17PM +0300, Konstantin Belousov wrote: > On Sun, Oct 05, 2014 at 06:39:54PM +0200, Stefan Farfeleder wrote: > > On Sat, Oct 04, 2014 at 02:21:54PM +0000, Bjoern A. Zeeb wrote: > > > > > > On 04 Oct 2014, at 08:08 , Mateusz Guzik wrote: > > > > > > > Author: mjg > > > > Date: Sat Oct 4 08:08:56 2014 > > > > New Revision: 272505 > > > > URL: https://svnweb.freebsd.org/changeset/base/272505 > > > > > > > > Log: > > > > Plug capability races. > > > > > > > > fp and appropriate capability lookups were not atomic, which could result in > > > > improper capabilities being checked. > > > > > > > > This could result either in protection bypass or in a spurious ENOTCAPABLE. > > > > > > > > Make fp + capability check atomic with the help of sequence counters. > > > > > > > > Reviewed by: kib > > > > MFC after: 3 weeks > > > > > > > > Modified: > > > > head/sys/kern/kern_descrip.c > > > > head/sys/sys/filedesc.h > > > > ??? > > > > > > > > > This file is included from user space. There is no opt_capsicum.h there. > > > Including an opt_* in the header file seems wrong in a lot of ways usually. > > > > > > I tried to add a bandaid for the moment with r272523 which (to be honest) makes it worse. > > > > > > This needs a better fix. > > > > Hi, > > > > this also breaks the nvidia-driver port (also with your fix). > > Is the breakage due to missing opt_capsicum.h file ? > If yes, what I proposed, i.e. making the new member unconditional, > should fix it without changes to the module build system. Yes, it breaks due to the missing file. Stefan