From owner-freebsd-apache@FreeBSD.ORG Sat Mar 27 02:10:17 2010 Return-Path: Delivered-To: apache@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8805D106564A for ; Sat, 27 Mar 2010 02:10:17 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id D3EDC8FC15 for ; Sat, 27 Mar 2010 02:10:16 +0000 (UTC) Received: (qmail 12586 invoked by uid 399); 27 Mar 2010 01:43:36 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 27 Mar 2010 01:43:36 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4BAD62C7.2050302@FreeBSD.org> Date: Fri, 26 Mar 2010 18:43:35 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.7) Gecko/20100218 Thunderbird/3.0.1 MIME-Version: 1.0 To: osa@FreeBSD.org, apache@FreeBSD.org X-Enigmail-Version: 1.0.1 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: %%RC_SUBR%% code in apache and nginx X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Mar 2010 02:10:17 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: RIPEMD160 Howdy, I am working on deprecating %%RC_SUBR%% and noticed the following: www/apache20/files/apache2.sh.in: %%PREFIX%%/etc/rc.d/apache2%%RC_SUBR_SUFFIX%% $1 ${profile} www/apache13-modssl/files/apache.in: %%PREFIX%%/etc/rc.d/apache%%RC_SUBR_SUFFIX%% $1 ${profile} www/nginx-devel/files/nginx.sh.in: %%PREFIX%%/etc/rc.d/nginx%%RC_SUBR_SUFFIX%% $1 ${profile} www/nginx/files/nginx.sh.in: %%PREFIX%%/etc/rc.d/nginx%%RC_SUBR_SUFFIX%% $1 ${profile} I'm not 100% sure what the goals for that code are, but you might want to review it with the goal of at minimum removing %%RC_SUBR%%. Also, the value of RC_SUBR_SUFFIX is empty on all supported versions of FreeBSD, and has been for some time. Anything you can do to simplify and/or eliminate that code would be greatly appreciated. Regards, Doug - -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEAREDAAYFAkutYscACgkQyIakK9Wy8PvSWQCgthSTOHa6GZIlTmOO52w8nLiQ zSMAoOK1E26G8X/4lKW3Fu5UL0PlwhJd =i7bi -----END PGP SIGNATURE-----