From owner-freebsd-current@freebsd.org Fri Apr 2 20:48:58 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BECC85B19A7; Fri, 2 Apr 2021 20:48:58 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FBsbZ4rrpz3t8v; Fri, 2 Apr 2021 20:48:58 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-qt1-f172.google.com with SMTP id c6so4487121qtc.1; Fri, 02 Apr 2021 13:48:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=GR0fuwP8JLuBzW8zt3CSKsdh28eW6DxRGP41syPN8QA=; b=TVCtcGcStHoPCFULKfTHlxNZe1jvXXAflGSKvQj4lrBFWGWN9d2MYwFnbEztbkTGnS twDG3bT3fRchVGl2QlE3Z4hX/nBR6XNtP5KVN7jmn3lRGG0GOxjEab5LNDSUHmg28xSW h8YVDabh45ZVQejGBc+iVHXjONS8m7bdDIMHQ+LWp+8XLvVQ+ngfoKPLu+otY+JmyRCR 3RRgvbeGO3EL/wquXfcP54nn8aG/S4qJiH0nFBSVZ7mB2CePWmR4HL+HozRoCPRP04/J nw3tDFjR8E14gdJ6yZEtC2hQ81xiBLSEio7ARIPLxjmgBnClDugs6BHEM+aD4k+JdtFb 2bJA== X-Gm-Message-State: AOAM530gChjnDnLo8gw6GDwYmh3aZ3yD2nIK0/D5tZg0+ak7pCfAiugB DfAt0zSDRZopii/VNXgm3SMQEZv0kqWGA8UU00k= X-Google-Smtp-Source: ABdhPJwZGHH12LHE7GzHDoP5715UmEpuYvyCs6txlpuP87fNIZ0fbqaDyrtXMLgFeSE+FxynmpDPeCArxkLWOYCFKAo= X-Received: by 2002:ac8:695a:: with SMTP id n26mr13298562qtr.20.1617396537434; Fri, 02 Apr 2021 13:48:57 -0700 (PDT) MIME-Version: 1.0 References: <1CD45BDA-FA62-4010-AE71-60AAF7B3E8F1@lists.zabbadoz.net> In-Reply-To: <1CD45BDA-FA62-4010-AE71-60AAF7B3E8F1@lists.zabbadoz.net> From: Adrian Chadd Date: Fri, 2 Apr 2021 13:48:45 -0700 Message-ID: Subject: Re: Correct net80211 channel flag. To: "Bjoern A. Zeeb" Cc: qcwap <1051244836@qq.com>, freebsd-wireless , freebsd-current Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4FBsbZ4rrpz3t8v X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2021 20:48:58 -0000 lemme go see (again). That's why I wanted to re-review it all before I landed stuff! -a On Fri, 2 Apr 2021 at 13:41, Bjoern A. Zeeb wrote: > > On 2 Apr 2021, at 6:44, Adrian Chadd wrote: > > > I've got this in my local tree now. > > That=E2=80=99s not a good idea? > > > I have a note to go dig up which > > draft I yanked this from and update it with reference to the draft and > > the current spec. > > > > Thanks for pointing this out! > > Aehm, am I missing something but I believe everywhere we use these > values > we do properly apply a maskshift apart from > ieee80211_vht_get_vhtcap_ie() where > we apply a shiftmask when setting them again after doing the logic > checks > so changing them will do us no good at all or am I looking at the wrong > tree? > > /bz