From owner-freebsd-hackers@freebsd.org Wed Dec 13 21:00:31 2017 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7FDA1E87055 for ; Wed, 13 Dec 2017 21:00:31 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x22a.google.com (mail-lf0-x22a.google.com [IPv6:2a00:1450:4010:c07::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 032D963BA5 for ; Wed, 13 Dec 2017 21:00:31 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x22a.google.com with SMTP id x204so4202072lfa.11 for ; Wed, 13 Dec 2017 13:00:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zWN9l6ma2BQbSFObo6WELqHFMkAJvU2Ei/Js70tYCjI=; b=qYy3Dj1kLUIjuD4DJwISsDOshlswI+aXmV59CSDs9f7ZHL+dYlF5pHR/9fN6Ns+lof PmE8blI1rbcIx+D1MkpuUQPIMVmRMm+twIG2QwZpQfUoDmUjnNwY2uYnoduN6zxuLEJb 4ZH1TEmaakliN3knX1Ri/7uVBoYz7pvrKQlpEtHRBb9xOgdvoutzb/ZBTWg4szjHONoh BoxVn605XNJ+Lm2VhSNj3gikLCFtk/oQ7wzDiXqrs2WKibG9kDWm8q2XyGNMj45Wq6uT Mo7s3eLFOJSS76DIxShonlZUCHzBuFylR9vAXI6T9MjtBJVPX0rlLBhijXgkK9gz6Yxr MwWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zWN9l6ma2BQbSFObo6WELqHFMkAJvU2Ei/Js70tYCjI=; b=dklbzkd9hEpe2cHa0B4mtfoZzLQEK1QmuD+39Du2seqN7QJJ11BKx43AofDaDyfvjt uOr+nCoKcnAnIAIS+XrNDlMJ51KBVSDFRpm0F9M9wMjFCuamvlLTw97YG75VWt6ancHD TI66ik+xIBtswmn9tBd2YpvX9EQdsljWogtrF766fboylUxX8jCWXjAj3e8NTD0NG8k0 d746i1GAtRslRelvSgYtj8dSHzEzWkwDEUw74qm8hSzyDop7qXCOXmlOHCdH9s8kgqSD hojvdtbdadyxLbECOpa5bAS2bzaJn2uloIKiRD4clVkiL38o6zV4M8urrfE1dVSGjk/h 4FwA== X-Gm-Message-State: AKGB3mKsjb1VH0EDWJ6z91Ks16AdX61J63FN6LaAcGgT+DyD17d8NY7Q oiQIzVO6IT2oldTo/QygmaTbUGXWG5WRgFahkuc= X-Google-Smtp-Source: ACJfBos1g658rXCNPhiEOHJcLLgNspga/ycqyFUfANTAk2gO8IJBXbno7CGDc9P2UuuPhWlLyJWqPDTVNOFLs83PvKs= X-Received: by 10.46.66.69 with SMTP id p66mr2259465lja.18.1513198829010; Wed, 13 Dec 2017 13:00:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.179.76.19 with HTTP; Wed, 13 Dec 2017 13:00:28 -0800 (PST) In-Reply-To: <20171213203522.2ytizwymoawwltle@t240> References: <20171213203522.2ytizwymoawwltle@t240> From: alan somers Date: Wed, 13 Dec 2017 14:00:28 -0700 Message-ID: Subject: Re: Avoid undefined shift overflow in dhclient To: Michael McConville Cc: "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 21:00:31 -0000 Thanks for your submission. While your reasoning seems correct, I'm still baffled that neither Clang nor Coverity complains about it. Fixed now. -Alan On Wed, Dec 13, 2017 at 1:35 PM, Michael McConville wrote: > It seems like I should have sent this patch to this list rather than > opening a > ticket: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208007 > > Thanks for your time, > Michael McConville > University of Utah > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" >