From owner-freebsd-ports  Fri Sep 21 17:57:37 2001
Delivered-To: freebsd-ports@freebsd.org
Received: from mail.inka.de (quechua.inka.de [212.227.14.2])
	by hub.freebsd.org (Postfix) with ESMTP id 1F84637B407
	for <freebsd-ports@freebsd.org>; Fri, 21 Sep 2001 17:57:32 -0700 (PDT)
Received: from kemoauc.mips.inka.de (uucp@)
	by mail.inka.de with local-bsmtp 
	id 15kb6o-0000we-03; Sat, 22 Sep 2001 02:57:30 +0200
Received: (from daemon@localhost)
	by kemoauc.mips.inka.de (8.11.6/8.11.6) id f8M0uSM59853
	for freebsd-ports@freebsd.org; Sat, 22 Sep 2001 02:56:28 +0200 (CEST)
	(envelope-from daemon)
From: naddy@mips.inka.de (Christian Weisgerber)
Subject: Re: ports/30713: 'gtar --version' segfaults
Date: Sat, 22 Sep 2001 00:56:26 +0000 (UTC)
Message-ID: <9ognjq$1i92$1@kemoauc.mips.inka.de>
References: <20010921224643.63992.qmail@nightshade.la.mastaler.com>
Originator: naddy@mips.inka.de (Christian Weisgerber)
To: freebsd-ports@freebsd.org
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

<jason-dated-1002321733.08bf3d@mastaler.com> wrote:

> >Description:
> 
> I just upgraded my gtar port to 1.13.23, and get a segmentation fault
> when I run 'gtar --version'.  Strangely, the program seems to work
> fine otherwise.

In an act of unprecedented ridiculousness gtar goes through contortions
with locales and iconv in order to obtain a "pretty" copyright
symbol, if the user's character set contains one.

On systems with insufficient locale support this code dereferences
a NULL pointer.  It doesn't happen for me on 5.0-CURRENT, but I've
seen it on another platform.

The patchlet below should fix this.

--- /usr/ports/archivers/gtar/files/patch-lib_copysym.c	Thu Jan  1 01:00:00 1970
+++ gtar/files/patch-lib_copysym.c	Sat Sep 22 02:43:08 2001
@@ -0,0 +1,14 @@
+
+$FreeBSD$
+
+--- lib/copysym.c.orig	Sat Sep 15 07:53:06 2001
++++ lib/copysym.c	Sat Sep 22 02:42:33 2001
+@@ -60,7 +60,7 @@
+ #endif
+     }
+ 
+-  if (*outcharset)
++  if (outcharset && *outcharset)
+     {
+       iconv_t conv = iconv_open (outcharset, "UTF-8");
+ 
-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message