From owner-svn-src-head@freebsd.org Thu Apr 16 08:58:54 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2F5892B70E8; Thu, 16 Apr 2020 08:58:54 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 492tSD6X07z4DTC; Thu, 16 Apr 2020 08:58:52 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 1ED22260244; Thu, 16 Apr 2020 10:58:45 +0200 (CEST) Subject: Re: svn commit: r328242 - head/lib/libregex To: Kyle Evans , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801220312.w0M3CQsC096350@repo.freebsd.org> From: Hans Petter Selasky Message-ID: Date: Thu, 16 Apr 2020 10:58:11 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <201801220312.w0M3CQsC096350@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 492tSD6X07z4DTC X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-4.99 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; IP_SCORE(-2.69)[ip: (-9.21), ipnet: 2a01:4f8::/29(-2.62), asn: 24940(-1.59), country: DE(-0.02)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 08:58:54 -0000 Hi Kyle, There is a sed regression between older 12.1 and 13-current likely caused by libregex changes. I will try to bisect: Can you have a look at this: Expected result: > printf "#define MEDIA_BUS_FMT_SRGGB16_1X16\t\t\t0x3020\n" | sed -e 's/.*FMT_//; s/\t.*//; s/.*/{ \"&\", MEDIA_BUS_FMT_& },/;' > { "SRGGB16_1X16", MEDIA_BUS_FMT_SRGGB16_1X16 }, Bad result: > printf "#define MEDIA_BUS_FMT_SRGGB16_1X16\t\t\t0x3020\n" | sed -e 's/.*FMT_//; s/\t.*//; s/.*/{ \"&\", MEDIA_BUS_FMT_& },/;' > { "SRGGB16_1X16 0x3020", MEDIA_BUS_FMT_SRGGB16_1X16 0x3020 }, A little further inspection shows \t does not work like expected in: s/\t.*//; Trying to quickly bisect. --HPS