From owner-svn-src-all@FreeBSD.ORG Fri Apr 15 17:12:47 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1D2E106564A; Fri, 15 Apr 2011 17:12:47 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-gw0-f54.google.com (mail-gw0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 408E98FC0A; Fri, 15 Apr 2011 17:12:46 +0000 (UTC) Received: by gwb15 with SMTP id 15so1442582gwb.13 for ; Fri, 15 Apr 2011 10:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=X4lRWRFBSrAZkddIyDdFWoQBgwYkjR5TwzKJkXTQiNI=; b=iZjD70FnQ7eN//htgBCu+BC/TWLC8f3KkD9V02KHK6obNLMYc5qOzYVqPQIhCCtT/Q qJ6d99/+1S32TFKFbnJOHZmf8acvGjp4PAd7huHHgyK/E1enlnqSAAa/1LMl7pnk4565 9FLkp8rjYuptPxZcXC4bZhenki34MpQWA8sJA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=Uy3qWrMqFr/3Su5Owb3zasV6JOr0IiKVX+wPN/pwTb+iR8S5wntmhfoRPPrHkpP/RM 3xHT2Qd4DNQEm5zOUyK53Ql0gYP6MJPI4GWT3Ibn5M7Evex538U6Kd4dAajN/8x86G0V q4gR+WVXqTr8p0qVjiRhzeMbLiFwzuwb8QWmQ= MIME-Version: 1.0 Received: by 10.236.187.97 with SMTP id x61mr918308yhm.476.1302885978243; Fri, 15 Apr 2011 09:46:18 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.236.103.34 with HTTP; Fri, 15 Apr 2011 09:46:18 -0700 (PDT) In-Reply-To: <20110415082706.GI48734@deviant.kiev.zoral.com.ua> References: <201104101707.p3AH736T054347@svn.freebsd.org> <201104141713.28311.jhb@freebsd.org> <20110415082706.GI48734@deviant.kiev.zoral.com.ua> Date: Fri, 15 Apr 2011 12:46:18 -0400 X-Google-Sender-Auth: _RO_QaLt0gdzLykRvUZ7euqs2GA Message-ID: From: Attilio Rao To: Kostik Belousov Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, trasz@freebsd.org, John Baldwin Subject: Re: svn commit: r220526 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2011 17:12:47 -0000 2011/4/15 Kostik Belousov : > On Thu, Apr 14, 2011 at 05:13:28PM -0400, John Baldwin wrote: >> On Sunday, April 10, 2011 1:07:03 pm Konstantin Belousov wrote: >> > Author: kib >> > Date: Sun Apr 10 17:07:02 2011 >> > New Revision: 220526 >> > URL: http://svn.freebsd.org/changeset/base/220526 >> > >> > Log: >> > =C2=A0 Some callers of proc_reparent() already have the parent process= locked. >> > =C2=A0 Detect the situation and avoid process lock recursion. >> > >> > =C2=A0 Reported by: =C2=A0 =C2=A0 =C2=A0Fabian Keil >> > >> > Modified: >> > =C2=A0 head/sys/kern/kern_exit.c >> >> Can we instead assert it is always held and fix callers that don't? =C2= =A0Using >> locked variables is messy and I'd rather avoid it when possible. =C2=A0W= e already >> require the caller to hold other locks for this operation. >> > I agree that this is ugly, and proper fix probably would be something els= e. > E.g. struct proc could grow another field that holds a pointer to the ucr= ed > it is accounted for, and locked with some global lock. As you already hold allproc_lock the process can't be distructed, then as I already pointed out to Tomasz, it should alright to just bump the refcount for cred and pass down, I guess. Attilio --=20 Peace can only be achieved by understanding - A. Einstein