From owner-freebsd-hackers@FreeBSD.ORG Mon Jan 8 19:21:01 2007 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6245816A8A5; Mon, 8 Jan 2007 19:21:01 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 20A8C13C457; Mon, 8 Jan 2007 19:20:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l08JKDdm068399; Mon, 8 Jan 2007 14:20:34 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Oliver Fromme Date: Mon, 8 Jan 2007 14:20:06 -0500 User-Agent: KMail/1.9.1 References: <200701061927.l06JRWoB095827@lurza.secnetix.de> In-Reply-To: <200701061927.l06JRWoB095827@lurza.secnetix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701081420.07376.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 08 Jan 2007 14:20:35 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2424/Mon Jan 8 11:46:49 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: erik.udo@gmail.com, freebsd-hackers@freebsd.org, dougb@freebsd.org Subject: Re: Init.c, making it chroot X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2007 19:21:01 -0000 On Saturday 06 January 2007 14:27, Oliver Fromme wrote: > M. Warner Losh wrote: > > Also, kenv(KENV_GET, ... is used a lot. Maybe it makes sense to have > > a simple kenvget call. Would make a few lines a little shorter if > > nothing else. > > KENV_GET is used three times. Using a wrapper function > would save 7 characters per call. I don't think it's > really worth it. But if you insist, I can update the > patch with such a function. I think just using kenv() is fine. -- John Baldwin