From owner-svn-src-head@freebsd.org Sat Jul 11 01:07:46 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DD4863511E5; Sat, 11 Jul 2020 01:07:46 +0000 (UTC) (envelope-from eugen@freebsd.org) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B3Wwy0RqPz4C2R; Sat, 11 Jul 2020 01:07:45 +0000 (UTC) (envelope-from eugen@freebsd.org) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13:0:0:0:5]) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id 06B17aBt014133 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 11 Jul 2020 01:07:39 GMT (envelope-from eugen@freebsd.org) X-Envelope-From: eugen@freebsd.org X-Envelope-To: yaneurabeya@gmail.com Received: from [10.58.0.10] (dadvw [10.58.0.10]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id 06B17WaM017174 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 11 Jul 2020 08:07:32 +0700 (+07) (envelope-from eugen@freebsd.org) Subject: Re: svn commit: r363088 - head/usr.bin/xinstall/tests To: Enji Cooper References: <202007102259.06AMxQxA013750@repo.freebsd.org> <54EAE812-6AAA-4882-B18E-75ED4FBB6628@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Eugene Grosbein Message-ID: <8ac0c5b6-1045-75a2-b7ff-ea7b76780cf0@freebsd.org> Date: Sat, 11 Jul 2020 08:07:23 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <54EAE812-6AAA-4882-B18E-75ED4FBB6628@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.2 X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record * 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Rspamd-Queue-Id: 4B3Wwy0RqPz4C2R X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; local_wl_from(0.00)[freebsd.org] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2020 01:07:46 -0000 11.07.2020 6:34, Enji Cooper wrote: >> On Jul 10, 2020, at 3:59 PM, Eugene Grosbein wrote: >> >> Author: eugen >> Date: Fri Jul 10 22:59:26 2020 >> New Revision: 363088 >> URL: https://svnweb.freebsd.org/changeset/base/363088 >> >> Log: >> Fix the tests for install(1): add support for STRIPBIN's -o option. > > Is this feature now completely gone? Are binaries being stripped properly in ports, etc? > Thanks, > -Enji > >>From install(1) on a host running r362553: > > ENVIRONMENT > The install utility checks for the presence of the STRIPBIN environment > variable and if present, uses the assigned value as the program to run if > and when the -s option has been specified. Nothing changed at all for install(1) called without -s option. With this option supplied, install(1) uses "strip -o dst src" instead of making another temporary copy and falls back to previous behaviour if strip/STRIPBIN does not support -o. Please take a look at https://reviews.freebsd.org/D25551 for details.