From owner-cvs-src@FreeBSD.ORG  Sun Aug  3 21:41:14 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8FA7A106568D;
	Sun,  3 Aug 2008 21:41:14 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 7C4CF8FC0A;
	Sun,  3 Aug 2008 21:41:14 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m73LfEr7000874;
	Sun, 3 Aug 2008 21:41:14 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m73LfEmn000873;
	Sun, 3 Aug 2008 21:41:14 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Message-Id: <200808032141.m73LfEmn000873@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	rwatson@repoman.freebsd.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Date: Sun, 3 Aug 2008 21:40:34 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: RELENG_7
Cc: 
Subject: cvs commit: src/sys/net if.c if_var.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Aug 2008 21:41:14 -0000

rwatson     2008-08-03 21:40:34 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_7)
    sys/net              if.c if_var.h 
  Log:
  SVN rev 181264 on 2008-08-03 21:40:34Z by rwatson
  
  Merge r180042 from head to stable/7:
  
    Introduce locking around use of ifindex_table, whose use was previously
    unsynchronized.  While races were extremely rare, we've now had a
    couple of reports of panics in environments involving large numbers of
    IPSEC tunnels being added very quickly on an active system.
  
    - Add accessor functions ifnet_byindex(), ifaddr_byindex(),
      ifdev_byindex() to replace existing accessor macros.  These functions
      now acquire the ifnet lock before derefencing the table.
    - Add IFNET_WLOCK_ASSERT().
    - Add static accessor functions ifnet_setbyindex(), ifdev_setbyindex(),
      which set values in the table either asserting of acquiring the ifnet
      lock.
    - Use accessor functions throughout if.c to modify and read
      ifindex_table.
    - Rework ifnet attach/detach to lock around ifindex_table modification.
  
    Note that these changes simply close races around use of ifindex_table,
    and make no attempt to solve the probem of disappearing ifnets.  Further
    refinement of this work, including with respect to ifindex_table
    resizing, is still required.
  
    In a future change, the ifnet lock should be converted from a mutex to an
    rwlock in order to reduce contention.
  
    Reviewed and tested by: brooks
  
  Revision   Changes    Path
  1.273.2.5  +69 -12    src/sys/net/if.c
  1.115.2.3  +4 -4      src/sys/net/if_var.h