From owner-freebsd-current@FreeBSD.ORG Sun May 15 20:37:39 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5EC7C16A4CE for ; Sun, 15 May 2005 20:37:39 +0000 (GMT) Received: from cheer.mahoroba.org (gw4.mahoroba.org [218.45.22.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 282F043DBB for ; Sun, 15 May 2005 20:37:38 +0000 (GMT) (envelope-from ume@mahoroba.org) Received: from lyrics.mahoroba.org (ume@lyrics.mahoroba.org [IPv6:3ffe:501:185b:8010:280:88ff:fe03:4841]) (user=ume mech=CRAM-MD5 bits=0)j4FKbBb9084925 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 16 May 2005 05:37:20 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Mon, 16 May 2005 05:37:08 +0900 Message-ID: From: Hajimu UMEMOTO To: current@FreeBSD.org References: <200505152015.j4FKFGsI021150@repoman.freebsd.org> User-Agent: Wanderlust/2.15.1 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.0.50 (i386-unknown-freebsd5.4) MULE/5.0 (SAKAKI) X-Operating-System: FreeBSD 5.4-STABLE X-PGP-Key: http://www.imasy.or.jp/~ume/publickey.asc X-PGP-Fingerprint: 1F00 0B9E 2164 70FC 6DC5 BF5F 04E9 F086 BF90 71FE Organization: Internet Mutual Aid Society, YOKOHAMA MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="Multipart_Mon_May_16_05:37:07_2005-1" X-Greylist: Sender succeded SMTP AUTH authentication, not delayed by milter-greylist-2.0b5 (cheer.mahoroba.org [IPv6:3ffe:501:185b:8010::1]); Mon, 16 May 2005 05:37:20 +0900 (JST) X-Virus-Scanned: by amavisd-new X-Virus-Status: Clean X-Spam-Status: No, score=-5.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.0.3 X-Spam-Checker-Version: SpamAssassin 3.0.3 (2005-04-27) on cheer.mahoroba.org Subject: HEAD UP: correct type of addrinfo.ai_addrlen and netent.n_net X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 May 2005 20:37:39 -0000 --Multipart_Mon_May_16_05:37:07_2005-1 Content-Type: text/plain; charset=US-ASCII Hi, I've committed to correct type of ai_addrlen member of struct addrinfo and n_net member of struct netent. Though it affects to 64 bit arch, I believe it doesn't break ABI backward comatibility. I'll remove padding for ABI backward comatibility after 2 weeks. When padding is removed, ABI backward comatibility will be lost on 64 bit arch. Sincerely, --Multipart_Mon_May_16_05:37:07_2005-1 Content-Type: message/rfc822 X-Sieve: CMU Sieve 2.2 Delivered-To: ume@freebsd.org Delivered-To: src-committers@freebsd.org Message-Id: <200505152015.j4FKFGsI021150@repoman.freebsd.org> From: Hajimu UMEMOTO Date: Sun, 15 May 2005 20:15:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/include netdb.h src/lib/libc/net getaddrinfo.c getnetbydns.c getnetbyht.c getnetbynis.c getnetnamadr.c netdb_private.h X-FreeBSD-CVS-Branch: HEAD Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0b5 (cheer.mahoroba.org [218.45.22.175]); Mon, 16 May 2005 05:17:10 +0900 (JST) X-Virus-Scanned: by amavisd-new X-Virus-Status: Clean X-Spam-Status: No, score=-5.6 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.0.3 X-Spam-Checker-Version: SpamAssassin 3.0.3 (2005-04-27) on cheer.mahoroba.org ume 2005-05-15 20:15:15 UTC FreeBSD src repository Modified files: include netdb.h lib/libc/net getaddrinfo.c getnetbydns.c getnetbyht.c getnetbynis.c getnetnamadr.c netdb_private.h Log: - The ai_addrlen of a struct addrinfo used to be a size_t, per RFC 2553. In XNS5.2, and subsequently in POSIX-2001 and RFC 3493, it was changed to a socklen_t. And, the n_net of a struct netent used to be an unsigned long integer. In XNS5, and subsequently in POSIX-2001, it was changed to an uint32_t. To accomodate for this while preserving ABI compatibility with the old interface, we need to prepend or append 32 bits of padding, depending on the (LP64) architecture's endianness. - Correct 1st argument of getnetbyaddr() to uint32_t on 32 bit arch. Stay as is on 64 bit arch for ABI backward compatibility for now. Reviewed by: das, peter MFC after: 2 weeks Revision Changes Path 1.36 +46 -5 src/include/netdb.h 1.69 +4 -1 src/lib/libc/net/getaddrinfo.c 1.30 +12 -8 src/lib/libc/net/getnetbydns.c 1.15 +5 -2 src/lib/libc/net/getnetbyht.c 1.18 +7 -4 src/lib/libc/net/getnetbynis.c 1.20 +8 -3 src/lib/libc/net/getnetnamadr.c 1.9 +1 -7 src/lib/libc/net/netdb_private.h --Multipart_Mon_May_16_05:37:07_2005-1 Content-Type: text/plain; charset=US-ASCII -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/ --Multipart_Mon_May_16_05:37:07_2005-1--