From owner-freebsd-bugs@freebsd.org Mon Dec 10 11:44:29 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7EBB01322759 for ; Mon, 10 Dec 2018 11:44:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 157AC74A3B for ; Mon, 10 Dec 2018 11:44:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id C74771322758; Mon, 10 Dec 2018 11:44:28 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A49FE1322757 for ; Mon, 10 Dec 2018 11:44:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2860C74A3A for ; Mon, 10 Dec 2018 11:44:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 4F89AAFE3 for ; Mon, 10 Dec 2018 11:44:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBABiRps004658 for ; Mon, 10 Dec 2018 11:44:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBABiR49004657 for bugs@FreeBSD.org; Mon, 10 Dec 2018 11:44:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 233907] Memory leakage in opencrypto for gcm algorithm Date: Mon, 10 Dec 2018 11:44:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: olegyankovic@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: 157AC74A3B X-Spamd-Result: default: False [-2.97 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; NEURAL_HAM_LONG(-0.99)[-0.994,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 11:44:29 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233907 Bug ID: 233907 Summary: Memory leakage in opencrypto for gcm algorithm Product: Base System Version: 11.2-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: olegyankovic@gmail.com Opencrypto subsystem has memory leakage when gcm algorithm is used. To make sure the bug exist it's enough to monitor memory usage through "vmstat -m | grep crypto" while opening and freeing new sessions for gcm (the auth part = of gcm: CRYPTO_AES_256_NIST_GMAC). Memory is allocated at swcr_newsession function: 929 case CRYPTO_AES_256_NIST_GMAC: 930 axf =3D &auth_hash_nist_gmac_aes_256; 931 auth4common: 932 len =3D cri->cri_klen / 8; 933 if (len !=3D 16 && len !=3D 24 && len !=3D = 32) { 934 swcr_freesession_locked(dev, i); 935 rw_runlock(&swcr_sessions_lock); 936 return EINVAL; 937 } 938=20=20=20=20=20 939 (*swd)->sw_ictx =3D malloc(axf->ctxsize, M_CRYPTO_DATA, 940 M_NOWAIT); and not released in swcr_freesession_locked function. I think it's enough to make something like this in swcr_freesession_locked: 1055 case CRYPTO_MD5: 1056 case CRYPTO_SHA1: case CRYPTO_AES_128_NIST_GMAC: case CRYPTO_AES_192_NIST_GMAC: case CRYPTO_AES_256_NIST_GMAC: 1057 axf =3D swd->sw_axf; 1058=20=20=20=20 1059 if (swd->sw_ictx) 1060 free(swd->sw_ictx, M_CRYPTO_DATA); 1061 break; --=20 You are receiving this mail because: You are the assignee for the bug.=