From owner-svn-src-head@FreeBSD.ORG Wed Aug 28 11:14:24 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9F0245DD; Wed, 28 Aug 2013 11:14:24 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: from mail-ve0-x229.google.com (mail-ve0-x229.google.com [IPv6:2607:f8b0:400c:c01::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 257F92EBB; Wed, 28 Aug 2013 11:14:24 +0000 (UTC) Received: by mail-ve0-f169.google.com with SMTP id db10so4239056veb.0 for ; Wed, 28 Aug 2013 04:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=l9Jqv8tr4kDuO+JTRwy6LSwpc3o/hX5ZWpkR6guSr2o=; b=kbUzlKd6WDk7qaqO4kJAoqrWhnrwS9TosIceCoY09SJhdNACAG7ondVFejlHS73iaB 98RISIusG9/OZcJaww3599Lx+47jx55iudX9iS8xN0SocwGI6GGEURVRKKZgDdLHCTF1 CyDQ2WxhWIjA8TrWltdIvxlYwzLh3wMLQ2aGJMGGwVE4EqpJvdddpDzhmcQRJKrzj5dl UxgwNfr851wH4sI8h7NwsmKfu7M1F5aJ68q1k/C/hQTuoQKDGPHAkWqK+M+os0KJAgfc yMI1ViKFrVysIOzsCBBoRaARIX8qf0nepd+1KyoJtJLHehWOMEER3L/H0491wHpWpLxr 3bNQ== MIME-Version: 1.0 X-Received: by 10.52.34.40 with SMTP id w8mr21272998vdi.7.1377688463255; Wed, 28 Aug 2013 04:14:23 -0700 (PDT) Sender: davide.italiano@gmail.com Received: by 10.220.65.132 with HTTP; Wed, 28 Aug 2013 04:14:23 -0700 (PDT) In-Reply-To: References: <201308281006.r7SA6KSq010737@svn.freebsd.org> Date: Wed, 28 Aug 2013 13:14:23 +0200 X-Google-Sender-Auth: l9Y4CV4b37i8_I_cBiQkqW1znfQ Message-ID: Subject: Re: svn commit: r254986 - head/sys/ufs/ufs From: Davide Italiano To: Ivan Voras Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Aug 2013 11:14:24 -0000 On Wed, Aug 28, 2013 at 12:53 PM, Ivan Voras wrote: > On 28 August 2013 12:44, Davide Italiano wrote: > >> Do you realize that this is a driven by commit change, right? And >> there's no technical motivatiion about this or experimental data that >> confirms you've chossen the right value? > >> I see from the archives that you didn't get any feedback by anyone >> working in the VM layer or by some UFS maintainer. >> I don't even comment about discussing -CURRENT changes in stable@. > > You have a point that this was a judgment call, but note that the last > change to dirhash tuning (maxmem) was also done by me. Since this is > -CURRENT, I will leave this commit in unless it proves detrimental in > the usual testing which goes on. > If 10.0 would be one or two years away, I would be OK with that. But we're already in code slush and in 10 days -CURRENT will become -STABLE'ish so I'm worried this change won't have the right exposure. I would be more happy to see it postponed, maybe after proper discussion and testing. I'm not against the change as-it-is, my point is that the project reached a point of maturity where 'judgment calls' doesn't work very well. It's more a matter of "how things are done" rather than "what things are done". > If you still feel strongly about this, contact me in private and we'll > investigate its effects in more detail. I prefer to see a public discussion about this. Maybe you should come up with some evidence that your change is helpful, even after this commit. -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare