Date: Sat, 16 Jun 2012 15:26:43 +0100 From: Chris Rees <crees@FreeBSD.org> To: Matthew Seaman <matthew@freebsd.org> Cc: freebsd-ports <freebsd-ports@freebsd.org> Subject: Re: [CFT] UNIQUENAME patches Message-ID: <CADLo83-phZB1X-QxNbMie1Gm2kOXfbOMZ8WmGRJpj6BcR8emCQ@mail.gmail.com> In-Reply-To: <4FDC9488.2010509@FreeBSD.org> References: <4FD8AFEC.6070605@FreeBSD.org> <CADLo83-Pr5Qqa6oUFKmfbLuuDOCiDQoiLVvjPfvJ1fT8ou0h9g@mail.gmail.com> <4FDC9488.2010509@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16 June 2012 15:13, Matthew Seaman <matthew@freebsd.org> wrote:
> On 16/06/2012 14:18, Chris Rees wrote:
>> That's great-- though rather than patching colliding-only ports, can't
>> we just add the category to it?
>>
>> .for cat in ${CATEGORIES}
>> UNIQUEPREFIX?=3D ${cat}
>> .endfor
>>
>> (copying the code from PKGCATEGORY; might be better off moving the
>> PKGCATEGORY code up higher and just using that).
>
> Yes. =A0I thought long and hard about doing that, but I opted not to for
> two reasons:
>
> =A0 1) Using the port name + a uniqueprefix where necessary produces what
> =A0 =A0 =A0is close to the minimal change required to give every port a
> =A0 =A0 =A0unique name. =A0The UNIQUENAME won't actually change for quite=
a
> =A0 =A0 =A0lot of ports under my scheme.
>
> =A0 2) As a way of future-proofing against reorganizations of the ports
> =A0 =A0 =A0tree. =A0What tends to happen is that a new category is invent=
ed
> =A0 =A0 =A0and a number of ports are moved into it. =A0My way should avoi=
d
> =A0 =A0 =A0changing the UNIQUENAME in the majority of cases.
>
> Remember that changing the UNIQUENAME changes where the record of the
> port options are stored, and either we annoy a lot of users by making
> them fill in a buch of dialogues all over again, or we have to invent
> some complicated mechanism copy the old options settings to the new
> directory. =A0(Yes -- this sort of thing will occur with the changes as
> written. =A0It can't be avoided entirely.)
>
> Plus I think it would be more natural and easier for maintainers and
> end-users to talk about (say) "phpmyadmin" rather than
> "databases-phpmyadmin."
Very thoughtful, OK. You'll also need some sort of cronjob then to
yell at people who duplicate UNIQUENAME then, rather like erwin's
LATEST_LINK script; ports/Tools/scripts/check-latest-link.
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-phZB1X-QxNbMie1Gm2kOXfbOMZ8WmGRJpj6BcR8emCQ>