From owner-cvs-all  Mon Oct 26 00:39:29 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id AAA17473
          for cvs-all-outgoing; Mon, 26 Oct 1998 00:39:29 -0800 (PST)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from vader.cs.berkeley.edu (vader.CS.Berkeley.EDU [128.32.38.234])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA17467;
          Mon, 26 Oct 1998 00:39:28 -0800 (PST)
          (envelope-from asami@vader.cs.berkeley.edu)
Received: from silvia.hip.berkeley.edu (sjx-ca126-43.ix.netcom.com [207.92.177.235]) by vader.cs.berkeley.edu (8.8.7/8.7.3) with ESMTP id AAA08304; Mon, 26 Oct 1998 00:38:52 -0800 (PST)
Received: (from asami@localhost) by silvia.hip.berkeley.edu (8.8.8/8.6.9) id AAA05993; Mon, 26 Oct 1998 00:38:49 -0800 (PST)
Date: Mon, 26 Oct 1998 00:38:49 -0800 (PST)
Message-Id: <199810260838.AAA05993@silvia.hip.berkeley.edu>
To: jkoshy@FreeBSD.ORG
CC: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
In-reply-to: <199810260310.TAA09873@freefall.freebsd.org> (message from Joseph
	Koshy on Sun, 25 Oct 1998 19:10:59 -0800 (PST))
Subject: Re: cvs commit: ports/misc/tet Makefile
From: asami@FreeBSD.ORG (Satoshi Asami)
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

 *   Do something sensible for make clean if TET_ROOT is not defined.  Add
 *   trailing slash to MASTER_SITE.

I don't understand this Makefile at all.

===
 :
NO_PACKAGE=             TET_ROOT needs to be set at compile time
 :
pre-extract:
.if !defined(TET_ROOT)
        @echo
        @echo "The environment variable \"TET_ROOT\" is not set."
        @echo "You must set it to the directory where you would like "
        @echo "this port to reside before attempting extraction."
        @echo
        @false
.else
        @true
.endif

# remove the TET_ROOT directory if it exists
pre-clean:
.if defined(TET_ROOT)
        if [ -d ${TET_ROOT} ]; then ${RM} -rf ${TET_ROOT}; fi
.else
        @true
.endif
 :
post-clean:
        ${RM} -rf ${TET_ROOT}

.include        <bsd.port.mk>
===

The ".else/@true" in pre-clean makes no sense.  You meant

.if defined(TET_ROOT)
pre-clean:
	${RM} -rf ${TET_ROOT}
.endif

?  (No need for the -d test either, rm -rf won't error out on
non-existent directories.)

What is "post-clean"?

Also, you should just make TET_ROOT a compilation option unless
there's a very good reason not to do so.  The spirit of ports
collection is to have a "canned" configuration that is easy to use,
and I see nothing wrong with having it default to ${PREFIX}/tet or
something.

Satoshi

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message