From nobody Fri Mar 27 08:33:38 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fhv764K6Kz6XQCY for ; Fri, 27 Mar 2026 08:33:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fhv761k6yz3Qtm for ; Fri, 27 Mar 2026 08:33:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774600418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0fqc38cR4V9lsoSCxQNlwJi4nct9vo3eiDdbOWc0pFQ=; b=Zl9R5C3CH0spFiQxYqc9HQ2x8HPpFug4hx8eMCpwytzkI48hTjC3fKu3MsfuC3bYOYKHN+ oN+GNYRLSMUI8aaYxmjThZTQc7pEodqkKOta5Gci5D+Ni5SXhfPaNfKe4uGphg/PSBNPhl oWtmAsaFWBskcIrKPXQ8Da5h8KTHUEfiekve89C1RgGLpvgCz/ogOTS6lhO1kVksHfNbWc hd7T5OKLdchf4ZVYnEUwonYeX5ecB/mE4Vp63labwhrdbvmckaXNTunfade6270bVVr2Xk PAEFcZ1A8y8L4IBvxey974Dg45QEfWN7qo1CImUq3fEpeNERTQ2LIj0ZTs3UtA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774600418; a=rsa-sha256; cv=none; b=KFsBt3798yDSjmtlIOmM7NGBp7WAniWX1TcOS2sVbM5JIbhsrAyNIc8xMFjyrBTssDB35J /09YAQxvTqTZTN/PDUk5/eL9EHl6cf0Rn8UVDfRWukbc5k5qve8vQpI0XJce6Sn7Y0DRK7 ovQ/gxBz4yIZ1sVOR9ENQqJixxD78524Al3spCRkdpSkgytD4Nv1ZameRNbjQTA3ODxjqv +6E2ZNWOHUORdIXCVlqo/kkrEtZdqBgiwUfDWoifJCi1LOmnH9otcWKyaUCVjQcNNLaq2L sALPETmIyrRK5/WRIrVT+VRaK3+xJaD9pQhQE42ZdvDmau5Zc6muluI7Z8Jnjw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774600418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0fqc38cR4V9lsoSCxQNlwJi4nct9vo3eiDdbOWc0pFQ=; b=G0ww6f2Kzbl+Rr+ehPxzDB9oWuEF4fRpCWzzCtBZO2mGEh+h9fX00E2UWj094zQ5YPAbcL 1nXTGnZhXbVzppdJywyme6l1k/EACBp1OC/EoDo9gtqJ3mC8t3VAyVlxQHk3esLWtDaE1f +8YCfNcT/xw/vpM55i8Z30Pf9zr2cEBm+m7QbsrF3IK+I7d0kwULq6jaSVmKmfFbyXh8mT zi1wPqKncmJgHnNFB+TveHjtkAsQb0dzkKmouMSWCVqR19WfmA9daHgpnsDikbtvyd0I9Z yAcZP1GgL5IwW3Zu+CBu8VFl+R5SMDSuqjkuV2T0T1rUKY5ehGajUEezglNk4g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fhv761FghzWrY for ; Fri, 27 Mar 2026 08:33:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1ece6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 27 Mar 2026 08:33:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Roger Pau =?utf-8?Q?Monn=C3=A9?= Subject: git: c562c81e315c - main - uart/pci: always disable MSI for generic devices List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: royger X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c562c81e315cd25bd35d5ece14ef9a3cb569cab5 Auto-Submitted: auto-generated Date: Fri, 27 Mar 2026 08:33:38 +0000 Message-Id: <69c640e2.1ece6.1828b643@gitrepo.freebsd.org> The branch main has been updated by royger: URL: https://cgit.FreeBSD.org/src/commit/?id=c562c81e315cd25bd35d5ece14ef9a3cb569cab5 commit c562c81e315cd25bd35d5ece14ef9a3cb569cab5 Author: Roger Pau Monné AuthorDate: 2026-03-26 19:59:24 +0000 Commit: Roger Pau Monné CommitDate: 2026-03-27 08:26:32 +0000 uart/pci: always disable MSI for generic devices The generic device pci_id structure in uart_pci_probe() already has PCI_NO_MSI appended to it's flags, however that information is not propagated into uart_pci_attach(). Assume that any device that doesn't match the known IDs is a generic UART device, and hence prevent the usage of MSIs. MFC: 2 weeks Reviewed by: imp Differential revision: https://reviews.freebsd.org/D56097 --- sys/dev/uart/uart_bus_pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/uart/uart_bus_pci.c b/sys/dev/uart/uart_bus_pci.c index 7087958cbfa9..b0d285e3c603 100644 --- a/sys/dev/uart/uart_bus_pci.c +++ b/sys/dev/uart/uart_bus_pci.c @@ -339,7 +339,8 @@ uart_pci_attach(device_t dev) * suggests this is only reliable when one MSI vector is advertised. */ id = uart_pci_match(dev, pci_ns8250_ids); - if ((id == NULL || (id->rid & PCI_NO_MSI) == 0) && + /* Always disable MSI for generic devices. */ + if (id != NULL && (id->rid & PCI_NO_MSI) == 0 && pci_msi_count(dev) == 1) { count = 1; if (pci_alloc_msi(dev, &count) == 0) {