From owner-cvs-all@FreeBSD.ORG  Thu Sep 30 08:55:04 2010
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 63CBB106566B
	for <cvs-all@FreeBSD.org>; Thu, 30 Sep 2010 08:55:04 +0000 (UTC)
	(envelope-from pav@FreeBSD.org)
Received: from raven.customer.vol.cz (raven.customer.vol.cz [195.250.144.108])
	by mx1.freebsd.org (Postfix) with ESMTP id BEA578FC21
	for <cvs-all@FreeBSD.org>; Thu, 30 Sep 2010 08:55:03 +0000 (UTC)
Received: from pav.hide.vol.cz (nat-application.b1.lan.prg.vol.cz
	[195.122.204.152]) (authenticated bits=0)
	by raven.customer.vol.cz (8.14.3/8.14.3) with ESMTP id o8U8strg074072
	(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);
	Thu, 30 Sep 2010 10:54:57 +0200 (CEST)
	(envelope-from pav@FreeBSD.org)
Message-ID: <4CA4505F.1080306@FreeBSD.org>
Date: Thu, 30 Sep 2010 10:54:55 +0200
From: Pav Lucistnik <pav@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.9.2.9) Gecko/20100921 Thunderbird/3.1.4
MIME-Version: 1.0
To: Stanislav Sedov <stas@FreeBSD.org>
References: <201009291312.o8TDCTwo029078@repoman.freebsd.org>
	<20100929165421.70c8064a.stas@FreeBSD.org>
In-Reply-To: <20100929165421.70c8064a.stas@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 195.250.144.108
X-Milter: Spamilter (Reciever: raven.customer.vol.cz;
	Sender-ip: 195.122.204.152; Sender-helo: pav.hide.vol.cz; )
Cc: cvs-ports@FreeBSD.org, Bernhard Froehlich <decke@FreeBSD.org>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/sysutils/zfsnap Makefile distinfo
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Sep 2010 08:55:04 -0000

On 2010/09/30 01:54, Stanislav Sedov wrote:
> On Wed, 29 Sep 2010 13:12:29 +0000 (UTC)
> Bernhard Froehlich<decke@FreeBSD.org>  mentioned:
>
>> decke       2010-09-29 13:12:29 UTC
>>
>>    FreeBSD ports repository
>>
>>    Modified files:
>>      sysutils/zfsnap      Makefile distinfo
>>    Log:
>>    - Update to 1.4.0
>
> It's usually beneficial if you also provide the short changelog of changes
> in the software, or at least a link to the changelog.  Especially in this
> case, when maintainer wrote it clearly in the PR.

It's not an usual practice.

>>
>>    PR:             ports/151017
>>    Submitted by:   Aldis Berjoza<aldis at bsdroot dot lv>  (maintainer)
>>    Approved by:    beat (co-mentor, implicit)
>>
>
>> |
>> | -# vim: set ts=8 sw=8:
>> |  .include<bsd.port.mk>
>
> Is this one required for version update?  If it was done intentionaly, it
> should be documented in the commit log. otherwise it looks like an accidential
> change.

Again, it's not a usual practice to have this in the Makefiles so the 
cleanup is understandable.

-- 
Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>