Date: Fri, 3 Mar 2023 17:13:09 +0100 From: Jan Martin Mikkelsen <janm@transactionware.com> To: Gleb Popov <arrowd@freebsd.org> Cc: freebsd-ports@freebsd.org Subject: Re: Possible regression in "make all-depends-list" Message-ID: <A9D01565-1BEA-473D-8CBB-2D3D774B60D1@transactionware.com> In-Reply-To: <CD312E4E-5097-4632-8912-884586DA998E@transactionware.com> References: <3EE35107-6152-4144-AFBC-CBD61EECB1AF@transactionware.com> <CALH631md9fW_DTLsxSqB5GHyUkyZj%2BfavM_%2BUkODxvuJuo3Y1g@mail.gmail.com> <CD312E4E-5097-4632-8912-884586DA998E@transactionware.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 2. Mar 2023, at 18:07, Jan Martin Mikkelsen =
<janm@transactionware.com> wrote:
>=20
> On 2. Mar 2023, at 17:38, Gleb Popov <arrowd@freebsd.org> wrote:
>>=20
>> On Thu, Mar 2, 2023 at 6:35=E2=80=AFPM Jan Martin Mikkelsen
>> <janm@transactionware.com> wrote:
>>>=20
>>> Running =E2=80=9Cmake all-depends-list=E2=80=9D on the hs-pandoc =
port shows none of the dependencies listed in the USE_CABAL variable in =
the Makefile. In the 2022Q2 branch, these dependencies were included.
>>=20
>> USE_CABAL dependencies aren't port dependencies. These deps are
>> compiled statically into the port, so from Ports Framework =
perspective
>> they are part of source files that make up the software being built.
>=20
> Thanks, I misdiagnosed that one. The problem was some files were =
discarded because of a bad checksum due to a Unicode translation issue. =
(Byte order marks added to a UTF8 file.)
>=20
>>> Running =E2=80=9Cmake all-depends-list=E2=80=9D on x11-wm/xfce4 =
shows x11-servers/xorg-server as a dependency, but it does not include =
all of the dependencies for xorg-server. For example:
>>>=20
>>> xfce4 $ echo $PORTSDIR
>>> /data/scratch/janm/p4/ports-2023.1/ports
>>> xfce4 $ make all-depends-list | egrep 'xorg-server|libxcvt'
>>> /data/scratch/janm/p4/ports-2023.1/ports/x11-servers/xorg-server
>>> xfce4 $ cd ../../x11-servers/xorg-server
>>> xorg-server $ make all-depends-list | egrep 'xorg-server|libxcvt'
>>> /data/scratch/janm/p4/ports-2023.1/ports/x11/libxcvt
>>>=20
>>> In the 2022Q2 branch the dependencies were included.
>=20
> This case still seems to be a regression, as far as I can see.
I tracked down the problem with the missing dependencies. This fixes it =
for me.
--- a/ports/Mk/Scripts/depends-list.sh 2023-03-02 11:46:56.000000000 =
1100
+++ b/ports/Mk/Scripts/depends-list.sh 2023-03-02 11:46:56.000000000 =
1100
@@ -76,7 +76,7 @@
;;
esac
if [ -f ${d}/Makefile ]; then
- if [ -n $f ]; then
+ if [ -n "$f" ]; then
export FLAVOR=3D$f
fi
break
Should I open a bug?
Regards,
Jan M.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A9D01565-1BEA-473D-8CBB-2D3D774B60D1>