Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 12 Jun 2004 06:51:47 GMT
From:      Marcel Moolenaar <marcel@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 54703 for review
Message-ID:  <200406120651.i5C6plUI089383@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=54703

Change 54703 by marcel@marcel_nfs on 2004/06/12 06:51:41

	In gdb_tx_mem, use pointers to unsigned char to avoid
	sign-extension. That breaks the construction of packets.

Affected files ...

.. //depot/projects/gdb/usr.bin/kgdb/packet.c#4 edit

Differences ...

==== //depot/projects/gdb/usr.bin/kgdb/packet.c#4 (text+ko) ====

@@ -310,8 +310,8 @@
 int
 gdb_tx_mem(const unsigned char *addr, size_t size)
 {
-	char sbuf[256];
-	char *dbuf, *p;
+	unsigned char sbuf[256];
+	unsigned char *dbuf, *p;
 	ssize_t res;
 
 	dbuf = (size > sizeof(sbuf)) ? malloc(size) : sbuf;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406120651.i5C6plUI089383>