From owner-freebsd-mobile  Tue Jul 31  8:43: 9 2001
Delivered-To: freebsd-mobile@freebsd.org
Received: from rover.village.org (rover.bsdimp.com [204.144.255.66])
	by hub.freebsd.org (Postfix) with ESMTP id 77A5737B403
	for <mobile@freebsd.org>; Tue, 31 Jul 2001 08:43:05 -0700 (PDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.11.3/8.11.3) with ESMTP id f6VFh3F88790;
	Tue, 31 Jul 2001 09:43:04 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.11.3/8.11.4) with ESMTP id f6VFh3w49545;
	Tue, 31 Jul 2001 09:43:03 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Message-Id: <200107311543.f6VFh3w49545@harmony.village.org>
To: Shizuka Kudo <shizukakudo_99@yahoo.com>
Subject: Re: Better patches 
Cc: mobile@freebsd.org
In-reply-to: Your message of "Tue, 31 Jul 2001 03:50:37 PDT."
		<20010731105037.47206.qmail@web11401.mail.yahoo.com> 
References: <20010731105037.47206.qmail@web11401.mail.yahoo.com>  
Date: Tue, 31 Jul 2001 09:43:03 -0600
From: Warner Losh <imp@harmony.village.org>
Sender: owner-freebsd-mobile@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-mobile.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-mobile>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-mobile>
X-Loop: FreeBSD.org

In message <20010731105037.47206.qmail@web11401.mail.yahoo.com> Shizuka Kudo writes:
: Warner,
: Looking at your patch pcic-stable.diff.14a,
: 
: Your pcic_pci_attach() has the following lines
: +		sc->bst = sp->bst = rman_get_bustag(sc->memres);
: +		sc->bst = sp->bsh = rman_get_bushandle(sc->memres);
: 
: do you mean to have sc->bst assigned twice? or should
: the second line be
: 
: sc->bsh = sp->bsh = ....

Yes.  It looks like sc->bsh might not be used, but you are nonetheless
correct.

Wraner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message