From owner-cvs-all@FreeBSD.ORG  Tue Jan 25 15:37:31 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 496B616A4CE; Tue, 25 Jan 2005 15:37:31 +0000 (GMT)
Received: from gw.celabo.org (gw.celabo.org [208.42.49.153])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E9D9C43D3F; Tue, 25 Jan 2005 15:37:30 +0000 (GMT)
	(envelope-from nectar@celabo.org)
Received: from lum.celabo.org (lum.celabo.org [10.0.1.107])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "lum.celabo.org", Issuer "celabo.org CA" (verified OK))
	by gw.celabo.org (Postfix) with ESMTP id 704823E2C23;
	Tue, 25 Jan 2005 09:37:30 -0600 (CST)
Received: by lum.celabo.org (Postfix, from userid 1001)
	id B4893594F89; Tue, 25 Jan 2005 09:37:29 -0600 (CST)
Date: Tue, 25 Jan 2005 09:37:29 -0600
From: "Jacques A. Vidrine" <nectar@FreeBSD.org>
To: Andrey Chernov <ache@nagual.pp.ru>,
	Poul-Henning Kamp <phk@FreeBSD.ORG>, src-committers@FreeBSD.ORG,
	cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Message-ID: <20050125153729.GF5662@lum.celabo.org>
Mail-Followup-To: "Jacques A. Vidrine" <nectar@FreeBSD.org>,
	Andrey Chernov <ache@nagual.pp.ru>,
	Poul-Henning Kamp <phk@FreeBSD.ORG>, src-committers@FreeBSD.ORG,
	cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
References: <200501250915.j0P9FW80032279@repoman.freebsd.org>
	<20050125094226.GA28188@nagual.pp.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050125094226.GA28188@nagual.pp.ru>
X-Url: http://www.celabo.org/
User-Agent: Mutt/1.5.6i
Subject: Re: cvs commit: src/sys/kern sys_generic.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jan 2005 15:37:31 -0000

On Tue, Jan 25, 2005 at 12:42:26PM +0300, Andrey Chernov wrote:
> On Tue, Jan 25, 2005 at 09:15:32AM +0000, Poul-Henning Kamp wrote:
> >     sys/kern             sys_generic.c 
> >   Log:
> >   Previously a read of zero bytes got handled in devfs:vop_read() but I
> >   missed that when the vnode bypass was introduced.
> >   
> >   Deal with zero length transfers before we even get to fo_ops->fo_read().
> 
> Please back it out. Zero bytes read may affect atime, now not.

I do not think that a zero byte read should not affect atime.

,----[ IEEE Std 1003.1, 2004 Edition ]
| Upon successful completion, where nbyte is greater than 0, read()
| shall mark for update the st_atime field of the file, and shall return
| the number of bytes read.
`----

Cheers,
-- 
Jacques A Vidrine / NTT/Verio
nectar@celabo.org / jvidrine@verio.net / nectar@FreeBSD.org