From owner-svn-src-head@freebsd.org  Fri Oct 13 07:51:45 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 28D07E3FE28;
 Fri, 13 Oct 2017 07:51:45 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [88.99.82.50])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D386D7C4FC;
 Fri, 13 Oct 2017 07:51:44 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [62.141.128.70])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id AFBE5260444;
 Fri, 13 Oct 2017 09:51:42 +0200 (CEST)
Subject: Re: svn commit: r324580 - head/sys/net80211
To: Adrian Chadd <adrian@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
References: <201710130649.v9D6n7cI036282@repo.freebsd.org>
 <b4ade0cf-8658-508d-f806-7db54d605b57@selasky.org>
 <CAJ-Vmo=7AVqRjnGmsTX5PJZ-0mSiSie1-gcw9LsAmYRTyS-DaQ@mail.gmail.com>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <be6c0415-1510-145f-5b46-d53609ff5b41@selasky.org>
Date: Fri, 13 Oct 2017 09:49:06 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <CAJ-Vmo=7AVqRjnGmsTX5PJZ-0mSiSie1-gcw9LsAmYRTyS-DaQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Oct 2017 07:51:45 -0000

On 10/13/17 09:45, Adrian Chadd wrote:
> no, it checks it.
> 
> 
> -a
> 
> 
> On 13 October 2017 at 00:11, Hans Petter Selasky <hps@selasky.org> wrote:
>> On 10/13/17 08:49, Adrian Chadd wrote:
>>>
>>>          if (ieee80211_check_rxseq_amsdu_more(rxs)) {
>>
>> ^^^ does this line also need a NULL check?
>>
>>
>>>                  ni->ni_rxseqs[tid] = rxseq;
>>> -               if (ieee80211_check_rxseq_amsdu(rxs))
>>> +               if ((rxs != NULL) && ieee80211_check_rxseq_amsdu(rxs))
>>>                          IEEE80211_NODE_STAT(ni, rx_amsdu_more_end);
>>
>>
>> --HPS
> 
> 

Then why are you checking that pointer twice? Why not make 
ieee80211_check_rxseq_amsdu_more() return false, if rxs is NULL?

--HPS