From owner-cvs-all Tue Sep 4 16:49:31 2001 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 447A237B403; Tue, 4 Sep 2001 16:49:21 -0700 (PDT) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id D6BB26AA31; Wed, 5 Sep 2001 09:19:45 +0930 (CST) Date: Wed, 5 Sep 2001 09:19:45 +0930 From: Greg Lehey To: John Baldwin Cc: Peter Wemm , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_shutdown.c Message-ID: <20010905091945.P85816@wantadilla.lemis.com> References: <20010904055510.050A4380C@overcee.netplex.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Tue, Sep 04, 2001 at 09:40:46AM -0700 Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tuesday, 4 September 2001 at 9:40:46 -0700, John Baldwin wrote: > > On 04-Sep-01 Peter Wemm wrote: >> John Baldwin wrote: >>> >>> On 02-Sep-01 Peter Wemm wrote: >>>> peter 2001/09/02 05:24:38 PDT >>>> >>>> Modified files: >>>> sys/kern kern_shutdown.c >>>> Log: >>>> The !RESTARTABLE_PANICS code has some loose ends. >>> >>> What is holding_giant for? Oh, and you do know that you are truly evil >>> incarnate now, right? >> >> I'm not sure. Matt added it in rev 1.107, but the code that sets it is >> #if 0'ed out. It is a real mess. > > Except the code to release it isn't #if 0'd out. > >> The other part of the diff was an accident that leaked from a local change. >> I've been meaning to back it out but just couldn't quite do it. Ian Dowse >> flagged it yesterday evening I think. I am amused at how few people had >> noticed it, and of those most had read the diff. > > Heh. We could leave it on in -current for all I care, except that it does > make all the useful messages scroll off the screen during a panic. :) > > \\|/ ____ \\|/ > \"@'/ .. \\`@\ > /_| \\__/ |_\\ > \\__U_/ > > Oh, and you forgot the > > Obtained from: Linux > > in the commit log. :-P Isn't this GPL'd code? Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message