From nobody Mon Jan 12 11:27:23 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dqVTl2gvQz6NT1l for ; Mon, 12 Jan 2026 11:27:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dqVTl1vtZz487G for ; Mon, 12 Jan 2026 11:27:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768217243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vqoWWDTOqcRcs1tfNl46BRMSb8Fzy/ArZVR/AyxYMV8=; b=V+MuR6fbvGzIoqthzMJSVVe9BaC6zksQNfP5VP2pIUMOK78WA+snHO73IriTXapoCN4C40 zrIJhizIyl4h+gMFeyVXXL8p+o/ByMPW6lLSInY4/FhumHiRkgiydXFxdF2mahtKoM2TND 0Ek/fzziDgneDrB3bd1BLk7xSH0CY7LLcvMLfdyPzakyuzxH0FAJQWNpO+zYVM/BWNC2PV 3Node3BeMeX92C/NzETJtZ2yhVlYL5OuoC4fSJ/ZwR2fFToC9k5bJ0evnhNZflGmGg4ztb WdYRxs3N3OH0hXjaPI0clmGo35F1uRjsYrHAM/1Hj7jfIuyJbNJIVYZRdn4Y/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768217243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vqoWWDTOqcRcs1tfNl46BRMSb8Fzy/ArZVR/AyxYMV8=; b=GKbnN/c6LC/xpl88D4ZnWl5s/k70Fs7z0aFvt42vSYZivV8G4dGxnZ/jLjR149KpPKoV5l 4uMdh8BXtTuqXdLjWjRpsvvvDLorfgilbBdougDuJ3Xk9iKoo/9l255riDhxVk/cj8gj6a JEXfW+zZ5kNJ8e91uar1AzgEm7opPZqJLUHkZI3DboXe7pwtPSqP/Ovr/zP7ar+/FzP++q HTGoX8buaHwd/i8Kxqn8WjEsXxqsZY/3lnD/2nImNV1YMQZB9SM9nuNffVk1QsshCi7INo HUtk5EqFVuV72bfP3A/dFwBre0cg/v/+rxchbJCDaG50KKwowjCRKt3qXW1U+A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768217243; a=rsa-sha256; cv=none; b=QK1ckEI5R/IgUDKbyEheWL9dGf8dBUPmafkhXEyKF6GDVncQXotnOtQFxUjagSDd9rfHuW hSns8fNYbK92+Md+6a3NyS+0g8Ex2+AlO7mAtjShuqQPDL8ItG1yK/w/yPV3LSMZdXK1z0 nF+0L8sQuhImFMzTpJrqSCGfI//2bJBfA/7XlEnbkYcbl/psgjIHKM+xiKBdvT9f1YkVuD IUDoLTyjsvBBYiGMVuhhDlTqZahzRQ6Z7mLSozyXA7+DcHqRibXX2ASZupGQkAQn9Hbort Ccpj+ZzQnNRlVmOgSKDgyTN6Zok2VK2iL+Ywk+rgL8Nem/TPniemthe5trkBtg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dqVTl17tvz8kr for ; Mon, 12 Jan 2026 11:27:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 35642 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 12 Jan 2026 11:27:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 6b69d6726a7d - main - sound: Unlock around uiomove() in midi_{read,write}() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6b69d6726a7d3455fb295abfcf9aedd48c580d4a Auto-Submitted: auto-generated Date: Mon, 12 Jan 2026 11:27:23 +0000 Message-Id: <6964da9b.35642.1f121c60@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=6b69d6726a7d3455fb295abfcf9aedd48c580d4a commit 6b69d6726a7d3455fb295abfcf9aedd48c580d4a Author: Christos Margiolis AuthorDate: 2026-01-12 11:27:15 +0000 Commit: Christos Margiolis CommitDate: 2026-01-12 11:27:15 +0000 sound: Unlock around uiomove() in midi_{read,write}() Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D54130 --- sys/dev/sound/midi/midi.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sys/dev/sound/midi/midi.c b/sys/dev/sound/midi/midi.c index c86f5fb41b14..8c38b00f15ad 100644 --- a/sys/dev/sound/midi/midi.c +++ b/sys/dev/sound/midi/midi.c @@ -391,9 +391,11 @@ midi_read(struct cdev *i_dev, struct uio *uio, int ioflag) used = MIN(used, MIDI_RSIZE); MIDIQ_DEQ(m->inq, buf, used); + mtx_unlock(&m->lock); retval = uiomove(buf, used, uio); if (retval) - goto err1; + goto err0; + mtx_lock(&m->lock); } /* @@ -457,9 +459,11 @@ midi_write(struct cdev *i_dev, struct uio *uio, int ioflag) used = MIN(MIDIQ_AVAIL(m->outq), uio->uio_resid); used = MIN(used, MIDI_WSIZE); + mtx_unlock(&m->lock); retval = uiomove(buf, used, uio); if (retval) - goto err1; + goto err0; + mtx_lock(&m->lock); MIDIQ_ENQ(m->outq, buf, used); /* * Inform the bottom half that data can be written