From owner-freebsd-current Fri Mar 21 6:58:22 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B8D837B401; Fri, 21 Mar 2003 06:58:21 -0800 (PST) Received: from sasami.jurai.net (sasami.jurai.net [66.92.160.223]) by mx1.FreeBSD.org (Postfix) with ESMTP id 928E943F3F; Fri, 21 Mar 2003 06:58:20 -0800 (PST) (envelope-from mdodd@FreeBSD.ORG) Received: from sasami.jurai.net (sasami.jurai.net [66.92.160.223]) by sasami.jurai.net (8.12.8/8.12.8) with ESMTP id h2LEwJCi075752; Fri, 21 Mar 2003 09:58:19 -0500 (EST) (envelope-from mdodd@FreeBSD.ORG) Date: Fri, 21 Mar 2003 09:58:19 -0500 (EST) From: "Matthew N. Dodd" X-X-Sender: winter@sasami.jurai.net To: Nate Lawson Cc: current@FreeBSD.ORG, wpaul@FreeBSD.ORG Subject: Re: Updated if_* attach/detach patches In-Reply-To: Message-ID: <20030321095558.O8716@sasami.jurai.net> References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 19 Mar 2003, Nate Lawson wrote: > Patches are at: > http://www.root.org/~nate/freebsd/if_pci/ I'd like to see calls to mtx_destroy() protected by a test for mtx_initialized(). In most cases this isn't strictly necessary but its not bad practice. -- | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | | http://www.jurai.net/~winter | For Great Justice! | ISO8802.5 4ever | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message