From owner-freebsd-bugs  Wed Apr 10 08:10:06 1996
Return-Path: owner-bugs
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id IAA13610
          for bugs-outgoing; Wed, 10 Apr 1996 08:10:06 -0700 (PDT)
Received: (from gnats@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id IAA13604
          Wed, 10 Apr 1996 08:10:03 -0700 (PDT)
Resent-Date: Wed, 10 Apr 1996 08:10:03 -0700 (PDT)
Resent-Message-Id: <199604101510.IAA13604@freefall.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org,
        patc@felix.antiquity.arts.su.edu.au
Received: from hyacinth.ucc.su.oz.au (ts-a12-1-52.ucc.su.OZ.AU [129.78.208.53])
          by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id IAA13350
          for <FreeBSD-gnats-submit@freebsd.org>; Wed, 10 Apr 1996 08:05:35 -0700 (PDT)
Received: (from patc@localhost) by hyacinth.ucc.su.oz.au (8.7.5/8.7.3) id BAA00672; Thu, 11 Apr 1996 01:07:56 +1000 (EST)
Message-Id: <199604101507.BAA00672@hyacinth.ucc.su.oz.au>
Date: Thu, 11 Apr 1996 01:07:56 +1000 (EST)
From: Pat Caldon <patc@hyacinth.ucc.su.oz.au>
Reply-To: patc@felix.antiquity.arts.su.edu.au
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: kern/1129: sys/i386/isa/matcd/matcd.c will not compile
Sender: owner-bugs@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         1129
>Category:       kern
>Synopsis:       matcd.c (Panasonic cdrom driver) will not compile
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 10 08:10:02 PDT 1996
>Last-Modified:
>Originator:     Pat Caldon
>Organization:
little or none
>Release:        FreeBSD 2.2-CURRENT i386
>Environment:

Panasonic CD-ROM on a Soundblaser card; -current as of April 7.

>Description:

The driver will not compile and spews out hudreds of error messages:
../../i386/isa/matcd/matcd.c:504: `isa_generic_externalize' undeclared here (not in a function)
../../i386/isa/matcd/matcd.c:504: initializer element for `kdc_matcd.kdc_externalize' is not
constant
../../i386/isa/matcd/matcd.c:504: `ISA_EXTERNALLEN' undeclared here (not in a function)
../../i386/isa/matcd/matcd.c:504: initializer element for `kdc_matcd.kdc_datalen' is not
constant
../../i386/isa/matcd/matcd.c:505: `kdc_isa0' undeclared here (not in a function)
../../i386/isa/matcd/matcd.c:505: initializer element for `kdc_matcd.kdc_parent' is not
constant
../../i386/isa/matcd/matcd.c:549: warning: `struct isa_device' declared inside parameter list
../../i386/isa/matcd/matcd.c:549: warning: its scope is only this definition or declaration,
[ and pages more ]

>How-To-Repeat:

# config GENERIC
# cd ../../compile/GENERIC
# make matcd.o

>Fix:

The following patch seems to work:

*** matcd.c.orig        Thu Apr 11 00:38:29 1996
--- matcd.c     Thu Apr 11 00:40:33 1996
***************
*** 364,376 ****
  #include      <sys/devconf.h>         /*<16>*/
  #include      <sys/conf.h>
  #include      <sys/kernel.h>
  #ifdef DEVFS
  #include      <sys/devfsext.h>
  #endif /*DEVFS*/
- #else /*FREE2*/
- #include      <i386/isa/isa.h>        /*<16>*/
- #include      <i386/isa/isa_device.h> /*<16>*/
- #endif        /*FREE2*/
  
  /*---------------------------------------------------------------------------
        Defines and structures
--- 364,374 ----
  #include      <sys/devconf.h>         /*<16>*/
  #include      <sys/conf.h>
  #include      <sys/kernel.h>
+ #include      <i386/isa/isa.h>        /*<16>*/
+ #include      <i386/isa/isa_device.h> /*<16>*/
  #ifdef DEVFS
  #include      <sys/devfsext.h>
  #endif /*DEVFS*/
  
  /*---------------------------------------------------------------------------
        Defines and structures


>Audit-Trail:
>Unformatted: