Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 Nov 2012 08:50:16 +0100
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Alfred Perlstein <alfred@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r242439 - in head/sys: dev/null geom kern sys
Message-ID:  <20121102075016.GH1399@garage.freebsd.pl>
In-Reply-To: <201211011701.qA1H15fb036810@svn.freebsd.org>
References:  <201211011701.qA1H15fb036810@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--J/zg8ciPNcraoWb6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 01, 2012 at 05:01:05PM +0000, Alfred Perlstein wrote:
> +	strlcpy(dumpdevname, devname, sizeof(dumpdevname));
> +	if (strlen(dumpdevname) !=3D strlen(devname)) {
> +		printf("set_dumper: device name truncated from '%s' -> '%s'\n",
> +			devname, dumpdevname);
> +	}

More "standard" way to check this is the following:

	if (strlcpy(dumpdevname, devname, sizeof(dumpdevname)) >=3D
	    sizeof(dumpdevname)) {
		printf("set_dumper: device name truncated from '%s' -> '%s'\n",
			devname, dumpdevname);
	}

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--J/zg8ciPNcraoWb6
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlCTezcACgkQForvXbEpPzTx7ACgnrILt6f0uPGzrfl/F8aLpoC7
VbMAoIoeu3hV4f8uAaBflYHLurwJM8vG
=49tL
-----END PGP SIGNATURE-----

--J/zg8ciPNcraoWb6--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121102075016.GH1399>