From owner-cvs-all Fri Feb 9 0:11:49 2001 Delivered-To: cvs-all@freebsd.org Received: from iguana.aciri.org (iguana.aciri.org [192.150.187.36]) by hub.freebsd.org (Postfix) with ESMTP id B42E137B491; Fri, 9 Feb 2001 00:11:23 -0800 (PST) Received: (from rizzo@localhost) by iguana.aciri.org (8.11.1/8.11.1) id f198Agg01263; Fri, 9 Feb 2001 00:10:42 -0800 (PST) (envelope-from rizzo) From: Luigi Rizzo Message-Id: <200102090810.f198Agg01263@iguana.aciri.org> Subject: Re: QUEUE macros considered harmful (was Re: cvs commit: src/usr.bin/lam lam.c) In-Reply-To: <20580.981704816@critter> from Poul-Henning Kamp at "Feb 9, 2001 8:46:56 am" To: phk@critter.freebsd.dk (Poul-Henning Kamp) Date: Fri, 9 Feb 2001 00:10:42 -0800 (PST) Cc: luigi@info.iet.unipi.it, bde@zeta.org.au, peter@netplex.com.au, mark@grondar.za, mikeh@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL43 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > >Simple example taken from the firewall code: > > As you say "Simple example". Most people can write a correctly > structured "make world" program. Try with an example from some > more complicated code. And if you don't want to use > in your code then don't. my point was exactly this: you do not need to make things unnecessarily complex. And yes, i carefully avoided the use of such macros in my code as the only data structure i needed was simple lists and hash tables. > I have been advocating changing the users of to > not grope around inside the structures in all kinds of bogus > and non-bogus manners. and i guess i am moving along similar lines, advocating readability and sensible choice of names in simple cases like the one i mention. cheers luigi ----------------------------------+----------------------------------------- Luigi RIZZO, luigi@iet.unipi.it . ACIRI/ICSI (on leave from Univ. di Pisa) http://www.iet.unipi.it/~luigi/ . 1947 Center St, Berkeley CA 94704 Phone: (510) 666 2927 ----------------------------------+----------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message