From owner-cvs-all Thu Sep 20 16: 5:51 2001 Delivered-To: cvs-all@freebsd.org Received: from peter3.wemm.org (c1315225-a.plstn1.sfba.home.com [24.14.150.180]) by hub.freebsd.org (Postfix) with ESMTP id 1A17E37B419; Thu, 20 Sep 2001 16:05:46 -0700 (PDT) Received: from overcee.netplex.com.au (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id f8KN5jM04025; Thu, 20 Sep 2001 16:05:45 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id B102F38FF; Thu, 20 Sep 2001 16:05:45 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Jonathan Lemon Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_environment.c In-Reply-To: <200109202009.f8KK9bu88534@freefall.freebsd.org> Date: Thu, 20 Sep 2001 16:05:45 -0700 From: Peter Wemm Message-Id: <20010920230545.B102F38FF@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Jonathan Lemon wrote: > jlemon 2001/09/20 13:09:37 PDT > > Modified files: > sys/kern kern_environment.c > Log: > Add a sysctl MIB 'kern.env', that dumps the contents of the kernel > environment from the loader, as well as the kernel's compiled in static > hints. Congratulations! you have just broken kenv(1). :-( This mib was addressable by index so that a userland program could pull them out, one by one. Also, kern_envp is dynamically flipped between the loader environment or the static environment, but subr_hints.c uses either the environment *or* static_hints[] but never both. IMHO, It is bogus reporting the static hints if we're running from the environment set as it will just cause confusion. I wish you had used a different MIB rather than breaking existing, *used* functionality. (It isn't used in the tree, but it is used by a whole bunch of scripts at work where we pass stuff across from netboot and netboot+ramdisk environments) Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message