From owner-freebsd-hackers@FreeBSD.ORG  Tue Oct 19 10:34:32 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id 4AC88106566C; Tue, 19 Oct 2010 10:34:32 +0000 (UTC)
Date: Tue, 19 Oct 2010 10:34:32 +0000
From: Alexander Best <arundel@freebsd.org>
To: Matthew Jacob <mj@feral.com>
Message-ID: <20101019103432.GA69208@freebsd.org>
References: <20101018235318.GA87158@freebsd.org> <4CBCE67C.1070106@feral.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CBCE67C.1070106@feral.com>
Cc: freebsd-hackers@freebsd.org
Subject: Re: SCSI_DELAY cleanup
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Oct 2010 10:34:32 -0000

On Mon Oct 18 10, Matthew Jacob wrote:
>  What problem are you solving by this change?

code cleanup.

the scsi delay value currently defaults to 2000ms. however that doesn't make
sense, since on almost all platforms it gets set to 5000ms in the default
config. what's the purpose of having a default value, if it is much more often
overwritten than actually used?

that's why this patch changes the default scsi delay value to 5000ms. now all
of the lines that were setting the scsi delay value to 5000ms can be removed.
also default values should be chosen very conservatively. users can always
lower the delay value via their kernel config or sysctl.

cheers.
alex

> 
> >any thoughts on this patch?
> >
> >i noticed the "default" SCSI_DELAY value of 2000ms was only used in very 
> >few
> >places so i thought it would make more sense making 5000ms the default and
> >adding a few special cases where SCSI_DELAY can in fact be lowered down to
> >2000ms.
> >
> >cheers.
> >alex
> >
> >
> >
> >_______________________________________________
> >freebsd-hackers@freebsd.org mailing list
> >http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> >To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
> 

-- 
a13x