Date: Mon, 21 Oct 2013 09:41:00 -0400 From: Eitan Adler <eadler@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, Alex Kozlov <ak@freebsd.org> Subject: Re: svn commit: r331046 - head/Mk/Scripts Message-ID: <CAF6rxgnMtVeS=dofW72rxPCF=405ed5CXb5-aDZFpepKnWmaSg@mail.gmail.com> In-Reply-To: <20131021064704.GA29510@ithaqua.etoilebsd.net> References: <201310201812.r9KICnwq080041@svn.freebsd.org> <CAF6rxg=iZAkgtZtHDUq6Sb_2t2bcW23xhrdCNkQtU-KFvF_a7Q@mail.gmail.com> <20131021064704.GA29510@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 21, 2013 at 2:47 AM, Baptiste Daroussin <bapt@freebsd.org> wrote: > On Sun, Oct 20, 2013 at 03:01:38PM -0400, Eitan Adler wrote: >> On Sun, Oct 20, 2013 at 2:12 PM, Alex Kozlov <ak@freebsd.org> wrote: >> > Author: ak >> > Date: Sun Oct 20 18:12:49 2013 >> > New Revision: 331046 >> > URL: http://svnweb.freebsd.org/changeset/ports/331046 >> > >> > Log: >> > - Add check for suid files and directories >> >> Can you please add an in-port variable to disable this (NEEDS_SUID / >> NEEDS_ROOT) or remove this check? >> >> Warnings which may be ignored are not very useful. >> > > I do not think this is really a good way. First NEED_ROOT is a temporary knob > and should die as soon a possible as everything should be doable as a user. As I said to Alex privately, it should be possible to run check-sanity across the tree and get *zero* results. If some warnings could be ignored people will start ignoring all of them or people will start to "fix" them incorrectly. Look at what happens with portlint warnings. There needs to be an in-port method of quieting bogus warnings. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnMtVeS=dofW72rxPCF=405ed5CXb5-aDZFpepKnWmaSg>