From owner-freebsd-gnome@FreeBSD.ORG Wed Dec 17 00:54:58 2014 Return-Path: Delivered-To: gnome@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B76405C3 for ; Wed, 17 Dec 2014 00:54:58 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9E765C7E for ; Wed, 17 Dec 2014 00:54:58 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sBH0swR0039029 for ; Wed, 17 Dec 2014 00:54:58 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 196041] [patch] unbreak x11/gnome-shell stage-qa on FreeBSD 8 Date: Wed, 17 Dec 2014 00:54:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: truckman@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Dec 2014 00:54:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196041 --- Comment #4 from Don Lewis --- (In reply to Jan Beich from comment #3) > Created attachment 150660 [details] > escape } > > Is this caused by base r214492? If so try the attached workaround. Do you mean the lack of the change in r214492? The revision history of sh/parser.c in stable/8 is: ------------------------------------------------------------------------ r221522 | jilles | 2011-05-06 05:49:32 -0700 (Fri, 06 May 2011) | 12 lines MFC r220903: sh: Do not word split "${#parameter}". This is only a problem if IFS contains digits, which is unusual but valid. Because of an incorrect fix for PR bin/12137, "${#parameter}" was treated as ${#parameter}. The underlying problem was that "${#parameter}" erroneously added CTLESC bytes before determining the length. This was properly fixed for PR bin/56147 but the incorrect fix was not backed out. Reported by: Seeker on forums.freebsd.org ------------------------------------------------------------------------ r214113 | obrien | 2010-10-20 11:25:00 -0700 (Wed, 20 Oct 2010) | 2 lines MFC r213811: c89 linkage and storage class (also covers r213744, r213760) Your fix also appears to work. The graphics/evince port also has this problem, see: -- You are receiving this mail because: You are the assignee for the bug.