From owner-svn-ports-all@freebsd.org Wed Aug 9 07:13:15 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B3B3DC5047; Wed, 9 Aug 2017 07:13:15 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B81D665698; Wed, 9 Aug 2017 07:13:14 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 8F50DBDD2D; Wed, 9 Aug 2017 09:13:11 +0200 (CEST) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 5E02EBDD39; Wed, 9 Aug 2017 09:13:07 +0200 (CEST) Subject: Re: svn commit: r447474 - head/www/rubygem-goldfinger To: Sunpoet Po-Chuan Hsieh Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Joseph Mingrone References: <201708061653.v76Gr9O9008539@repo.freebsd.org> <939bd115-95a7-f0dc-f018-b276488a091c@FreeBSD.org> From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: <9a9ec899-701a-0d7c-c679-e2f7a977e47b@FreeBSD.org> Date: Wed, 9 Aug 2017 09:13:03 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="e9dnmQK44dFrcrjlnwNETUIMVHfUPOFso" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Aug 2017 07:13:15 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --e9dnmQK44dFrcrjlnwNETUIMVHfUPOFso Content-Type: multipart/mixed; boundary="RuugP1cTclnPW8ap8ia1JtSGtXBKVDn1n"; protected-headers="v1" From: Mathieu Arnold To: Sunpoet Po-Chuan Hsieh Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Joseph Mingrone Message-ID: <9a9ec899-701a-0d7c-c679-e2f7a977e47b@FreeBSD.org> Subject: Re: svn commit: r447474 - head/www/rubygem-goldfinger References: <201708061653.v76Gr9O9008539@repo.freebsd.org> <939bd115-95a7-f0dc-f018-b276488a091c@FreeBSD.org> In-Reply-To: --RuugP1cTclnPW8ap8ia1JtSGtXBKVDn1n Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: fr Le 08/08/2017 =C3=A0 20:57, Sunpoet Po-Chuan Hsieh a =C3=A9crit : > On Mon, Aug 7, 2017 at 4:53 AM, Mathieu Arnold > wrote: > > Hi, > > Le 06/08/2017 =C3=A0 18:53, Sunpoet Po-Chuan Hsieh a =C3=A9crit : > > Author: sunpoet > > Date: Sun Aug 6 16:53:09 2017 > > New Revision: 447474 > > URL: https://svnweb.freebsd.org/changeset/ports/447474 > > > > > Log: > > Use PORTVERSION > > Please revert. DISTVERSION is the preferred way of setting upstream= 's > version. > > https://www.freebsd.org/doc/en/books/porters-handbook/makefile-nami= ng.html#makefile-versions > > > > Hi mat, > > Here's my reason of this change. (jrm@ is cc'd). > The majority of the ports tree (and almost all rubygem ports) use > PORTVERSION. [1] > It's my understanding that we use PORTVERSION in most cases. Yes, it is because it took me a while to document that we should all be using DISTVERSION and almost never PORTVERSION. > When upstream use versions like 1_2_3, 4.5-alpha6 or so, we use > DISTVERSION instead. > > Before I revert it, could you make it clear when to use PORTVERSION > and DISTVERSION? It is explained in the porter's handbook, always use DISTVERSION except when there is no version in the distribution file, or when DISTVERSION gives an incorrect PORTVERSION. --=20 Mathieu Arnold --RuugP1cTclnPW8ap8ia1JtSGtXBKVDn1n-- --e9dnmQK44dFrcrjlnwNETUIMVHfUPOFso Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJZirYCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IlBcP/0EDCMbeAap0zw2SdJCJIMpD 0NP7qordDz9d6FOFjCg8svEp3gbTJXawr8PpFQ1pkL2/ZtLI/RAMSK5d35UWjO2V +Mj6xkB8rg8w3K5JTTDM/k4gypujMlnQUVwC9A05DBNMB+678nlfQd2HyWTY/j3g TPV8ONlgeDvyzofxwAVSLDtQBHIT3sWJrOw93w7VbzX978gO0vgpQrEZd352NQad gGdZuvab7H9MKAyz8zlJ3FmyrYDILlcP6FEmjLuYl+zPcnwT0cF7la4Z4A7TW0Tx HzPozcXlL9dB6zDsrd+0asqJelU6Zh6WBLI0hPM5O83UAWquRwa68gee1KiQdInN VSyRkRdOjhBDVPNvc5MEMtUaLnMAOkCFvYHnNk+h49PB89kR2+oH2yrVElOg/Amc +J3uSjfQQDl2+xKGLgti3PeQM9yoNgNQ1GmR4p+4AwlQbj5KjdFMQuMQRcFRJdy6 G6Rpv1ynNHGh7+Pk3Kh0buMdTz/tMrNaBOb3VeS4Id5oNwQWOhs++XJfesSFFz1z TavQk/8xrFn+e5EP01Qcm++AwZSOloTl/0tUt4Mwr1h03HXE1S+ExHBQmIyQYN/6 XHln7cxjMuN+zQQxVQ3DPAH2fT4NlmeQ9ij7VuVf3cGU13FnV50Wb+xYYxol4YbX Y9PnlXY8+9M9MG1eSv87 =U5Lh -----END PGP SIGNATURE----- --e9dnmQK44dFrcrjlnwNETUIMVHfUPOFso--