From owner-svn-src-head@freebsd.org  Thu Nov 24 19:39:37 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 82B79C53F66;
 Thu, 24 Nov 2016 19:39:37 +0000 (UTC) (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id 45CF429C;
 Thu, 24 Nov 2016 19:39:36 +0000 (UTC) (envelope-from des@des.no)
Received: from desk.des.no (smtp.des.no [194.63.250.102])
 by smtp.des.no (Postfix) with ESMTP id ADFEAA7C5;
 Thu, 24 Nov 2016 19:39:35 +0000 (UTC)
Received: by desk.des.no (Postfix, from userid 1001)
 id 45A9B4E70; Thu, 24 Nov 2016 20:39:37 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: John Baldwin <jhb@freebsd.org>
Cc: Marcelo Araujo <araujobsdport@gmail.com>, araujo@freebsd.org,
 src-committers@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org
Subject: Re: svn commit: r309109 - head/lib/libutil
References: <201611241450.uAOEoLA5079215@repo.freebsd.org>
 <CAOfEmZgexP65RKz1=WxcFBWTYGYbnSHWMzknkGAeFN=DwjBL8A@mail.gmail.com>
 <861sy0n8re.fsf@desk.des.no> <2094160.1ufjjsmd6m@ralph.baldwin.cx>
Date: Thu, 24 Nov 2016 20:39:37 +0100
In-Reply-To: <2094160.1ufjjsmd6m@ralph.baldwin.cx> (John Baldwin's message of
 "Thu, 24 Nov 2016 11:11:21 -0800")
Message-ID: <86vavc3bwm.fsf@desk.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Nov 2016 19:39:37 -0000

John Baldwin <jhb@freebsd.org> writes:
> Of course, there's only one person who has touched flopen [...]
> Perhaps you were just warning yourself? :)

Precisely.  If memory serves, I wrote that comment after receiving a
patch from someone who made the same mistake that I had already made and
reverted *twice*.  It's the logical, sane thing to do: replace a BSD
primitive with the equivalent POSIX primitive, except the latter has
subtly different semantics and works in some of flopen(3)'s typical use
cases, but not all, and crucially, not in the pidfile(3) case.

I just remembered that I wrote a unit test for flopen(3).  So maybe the
comment is redundant...  if you assume that people build and run the
tests, and I'm willing to bet that they don't, because our test
framework is not very developer-friendly.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no