Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Feb 2025 18:14:39 +0000
From:      Colin Percival <cperciva@tarsnap.com>
To:        "Bjoern A. Zeeb" <bz@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org,  dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 61ce42253180 - main - wlanstats: move from tools to usr.sbin
Message-ID:  <010001952491a2d8-75405478-d189-46d2-8468-fa753eb3c0af-000000@email.amazonses.com>
In-Reply-To: <26533875-n160-op63-qn3o-qpq1o6n55o34@SerrOFQ.bet>
References:  <202502190257.51J2vRTI049767@gitrepo.freebsd.org> <0100019521bc3080-e3de9a98-0421-4ce6-8cd4-f28ffd86f7b9-000000@email.amazonses.com> <26533875-n160-op63-qn3o-qpq1o6n55o34@SerrOFQ.bet>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2/20/25 09:15, Bjoern A. Zeeb wrote:
> On Thu, 20 Feb 2025, Colin Percival wrote:
>> On 2/18/25 18:57, Bjoern A. Zeeb wrote:
>>> commit 61ce422531805307d413bf04c9ad1aabd7f3a879
>>> Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
>>>
>>>      wlanstats: move from tools to usr.sbin
>>
>> Looks like this resulted in it being compiled with a higher WARNS, which
>> broke the build on some platforms (so far powerpc and powerpcspe have
>> failed the weekly snapshots):
>>
>>> /usr/src/usr.sbin/wlanstats/wlanstats.c:842:29: error: cast from 'struct 
>>> bsdstat *' to 'struct wlanstatfoo_p *' increases required alignment from 4 
>>> to 8 [-Werror,-Wcast-align]
>>>   842 |         struct wlanstatfoo_p *wf = (struct wlanstatfoo_p *) sf;
>>>       |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Please fix the build before you MFC. :-)
> 
> I am on it.  I had done a build on amd64, arm64, and i386 and fixed the
> build breakage from Gleb from Decmeber and the line next to it.

Thanks!  Please send me an email once this is committed (I might not notice
the commit go into the tree) so I can restart the weekly snapshots -- enough
of the builds failed that it's worth re-running them once the tree is fixed.

-- 
Colin Percival
FreeBSD Release Engineering Lead & EC2 platform maintainer
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?010001952491a2d8-75405478-d189-46d2-8468-fa753eb3c0af-000000>