From owner-freebsd-ports Tue Dec 18 13: 0: 9 2001 Delivered-To: freebsd-ports@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 99C1C37B417 for ; Tue, 18 Dec 2001 13:00:02 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id fBIL02X62767; Tue, 18 Dec 2001 13:00:02 -0800 (PST) (envelope-from gnats) Date: Tue, 18 Dec 2001 13:00:02 -0800 (PST) Message-Id: <200112182100.fBIL02X62767@freefall.freebsd.org> To: freebsd-ports@FreeBSD.org Cc: From: Steve Price Subject: Re: ports/32917: installing ports may fail if $GREP_OPTIONS is set Reply-To: Steve Price Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR ports/32917; it has been noted by GNATS. From: Steve Price To: clemensF Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: ports/32917: installing ports may fail if $GREP_OPTIONS is set Date: Tue, 18 Dec 2001 14:52:24 -0600 On Tue, Dec 18, 2001 at 09:38:19PM +0100, clemensF wrote: > > now lemme get this straight: if $GREP_OPTIONS is unset in the make files, > they are *not exported up* to the enclosing environment of the caller, they > only last for the make process. Yes. > so, yes, this little thing should definitely be added to the bsd.ports.mk. > the entire environment should be cleaned up and standardized in this file. > this will not disturb anything, but it will save people a lot of headaches. I don't think that this will ever be put in bsd.port.mk. The reason being is that bsd.port.mk can't possibly catch every case for every program that uses environment variables. GREP_OPTIONS is not set by default and not required to use grep(1). If you choose to use GREP_OPTIONS then you are responsible for what breaks because of it. Also as I said before someone might have a valid reason for setting GREP_OPTIONS to something that doesn't break a bunch of ports. If it unset in bsd.port.mk then those people will complain about it being reset. Your best course of action is to add it to /etc/make.conf and see if that works. -steve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message