From nobody Tue Apr 21 15:41:31 2026 X-Original-To: freebsd-testing@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g0RRd1d7jz6WtYb for ; Tue, 21 Apr 2026 15:41:49 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g0RRc3v77z3LTn for ; Tue, 21 Apr 2026 15:41:48 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-65c0891f4e9so7329554a12.1 for ; Tue, 21 Apr 2026 08:41:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776786107; cv=none; d=google.com; s=arc-20240605; b=boPPEKSYNgt/JclesE7RVONG70epwL2ALRjYjb7Hy41RCz85Udgf3YVWCWnopctJ1h pAK9OaWC/EVdO2fR3YLA2xuAQFVlz0nhJ72Q/dFrR4/QWO0mBgRpLuO7Dq5aQpXru52y 30pq9cu36zi4Oc3JaIX2Als3mMKkjB2iMgAPARnOT3y2GNSxQtb5HG/O7yxxKirSbNBU Mybop3Wh+AOIi4AE+/0J7BQpCDxAhONSZ8XHHt6u7Eua3ipzgrLdif3ymqzZx/lF+pyh ymIiOtv/xhRFN307oiq/BBno8GUvXhx4azHzIe3OcyI7gp5fsX3tKR6hgBATZGOu7yLA x3RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=DvzfblESoSFk+PTEWsK6BH7k+1q2MbKHyZmBxuoESho=; fh=PQPw1mCwQriwC61i4/6EVcEgbLxf4fHtKP5V2bgwYVk=; b=cswmKRIqTMK16AP6JUHjg02loOfx2geG5yE+wRrlnbHQaxY5BuEMxd+Up0OsPHddNJ jE68oe8TWchSAbFZWmP8VZvJ0lRYqer3RJumtzUoDJu/66Z4sBOv1x0aAjgB16HzjIDo E3+Bn4uPLb5z0f0yRwaghALZc7lt7p5gTBzbyaIWO+9rdEfSJNOISE9YvC4RgOG/OEa+ CzuepbTcZpJyC1S0VLxDXkDPrDEtE1x4zHjkhMHAp5TcrO+CdKt5GC8IhVUZARsfITmS x8HAc4e452yQnjrYbcCZTkLOW5+dridZycrGzOaOO6DJKByw4Hcmk6zCbRagI9cIufe5 w8Vw==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776786107; x=1777390907; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DvzfblESoSFk+PTEWsK6BH7k+1q2MbKHyZmBxuoESho=; b=S4yhiLLsku4yvM2zP1BI+ld3Wf6cmzcb+2PFRT1M91B/WLq2FcpeC1916p3USdzTzL /YSc4bZI32ovox8RBQTyFlon3TBUeowkbDozg4h6CAAcYmd9dq4VmJaMgobcJkOr2eoR kEflACMHtNUo0KYirNwKMWLYLIPE5qRPJOZg3edPCkVAOqabl+ZGBREMzfjknYig2sGw /pNKeVTdXZNEnJmFZfWLr7GntEhNl5p/PN1ygeNE8aQUR63SGYDI7hPcUiJ1HCwlglUs n6JudiTX1xHmHtQET2w3vigLAHxKvf0Z+oThLvEip0rFhDkKocMptzHzxJsPTlqM7J3O efuw== X-Gm-Message-State: AOJu0YzDxi/Y+y4XKCi6GVUNDOi1/IpUNH3gj7vvyix8Zo5AxUB8aZe4 qPtj3Z6sgrfLeeawhsyIfmgIy2P+JQgo9MedEswnlxvgaDCPPbTsGA+HUOknW07qym21s4oJ9Am 2/Y4T1Ur+9cmkRQ+g0VD9/bwty6vWx26DKg== X-Gm-Gg: AeBDieuduSAAESxmk6Fr0RO7lImEcCTMree6N5L8TtrOb27ffDSAfFg03lTSFqrJa+g res2lYmFOR1vnqvxcijAVSS+3zIiaY+wo+YPYH5GObcvW1l09xo+6jzv9m24XnnM9xweHD3HF/q gFAKPaaR3B5xoBGfn3e3ce4v2tCG5kZXOqKlB0VfxXmxQVni4O1khcYypdgrJ/7Uhz7BleSV4CO c2PpTKwwE55/74vrNjYOq0vXU8loJw2aqy60w85LQzTYXE4HPPIjr5bhmlQiEydXZBKsvK8dMG5 MO1UvyyY4vtdEaCQx/d5pg3kXqsvSwEUgOPr4S/VUVXbXLiCvmyb/yjOMzs+RX+P1w8UCt2wYLk h/ZA= X-Received: by 2002:aa7:d7ca:0:b0:66e:378d:2e56 with SMTP id 4fb4d7f45d1cf-672bfd8b0b5mr6170105a12.6.1776786106388; Tue, 21 Apr 2026 08:41:46 -0700 (PDT) List-Id: Testing List-Archive: https://lists.freebsd.org/archives/freebsd-testing List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-testing@freebsd.org Sender: owner-freebsd-testing@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Tue, 21 Apr 2026 09:41:31 -0600 X-Gm-Features: AQROBzDxHBLGdyFyg_r38tWN-tYV8xqFdEZoxnsM15_C4JSNEEh2iCQeIIAhYqQ Message-ID: Subject: Re: pjdfstest integration To: Mark Johnston Cc: freebsd-testing@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4g0RRc3v77z3LTn X-Spamd-Bar: ---- On Tue, Apr 21, 2026 at 9:11=E2=80=AFAM Mark Johnston w= rote: > > Hi, I noticed that we install pjdfstest to /usr/tests/sys/pjdfstest, > but: > - it's not hooked up to the test suite, i.e., > "kyua test -k /usr/tests/Kyuafile" doesn't run it, > - contrib/pjdfstest doesn't seem to be updated regularly, > - the configuration is hard-coded, i.e., I can't easily run it against a > filesystem of my choice. > > How hard would it be to parameterize the tests so that we can run the > tests again a list of filesystems? For each filesystem we'd have some > little script that sets up some scratch space, creates an empty > filesystem and points pjdfstest at it. In some cases we'd need the test > runner to specify some additional variables, e.g., for p9fs you want the > test runner to provide a share, as we currently only support the virtio > transport. I'm not sure if kyua can pass variables to a TAP test, so > the solution might be to wrap each pjdfstest run with an ATF test case > which handles the setup. > > Is anyone interested in working on these things? Yes, yes and yes. I was indeed working on a change to pjdfstest which, among other things, would read a config file for each file system under test. The config file specifies things like whether posix_fallocate is supported on that file system and which file flags are supported. The change also drastically speeds up pjdfstest's runtime. We did that as part of GSoC 2022. The status of the project is that it's 99% complete, but requires somebody to comb through 4000 SLOC line by line to make sure nothing got left out. That's very tedious, which is why nobody has done it yet. I would LOVE to get it finished, but I've never made the time. The rewrite also relies on some ugly macro syntax. We did that deliberately to save time, but it does make the code ugly, and a little bit harder to review. It might be worth investing the time to rewrite those macros more cleanly. Using the new pjdfstest, it would be quite easy to add an ATF test for each file system. atf-sh would format the file system under test, then call pjdfstest with the appropriate per-filesystem config file.