From owner-freebsd-ports@FreeBSD.ORG Thu May 23 14:14:24 2013 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 415A263A for ; Thu, 23 May 2013 14:14:24 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 225DF5F7 for ; Thu, 23 May 2013 14:14:24 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r4NEENJS034203 for ; Thu, 23 May 2013 14:14:23 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r4NEENor034191 for ports@freebsd.org; Thu, 23 May 2013 14:14:23 GMT (envelope-from bdrewery) Received: (qmail 974 invoked from network); 23 May 2013 09:14:21 -0500 Received: from unknown (HELO ?173.160.118.90?) (freebsd@shatow.net@173.160.118.90) by sweb.xzibition.com with ESMTPA; 23 May 2013 09:14:21 -0500 Message-ID: <519E243D.9020501@FreeBSD.org> Date: Thu, 23 May 2013 09:14:21 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: Plans for making MAKE_JOBS_SAFE the default? References: <50463F7F.2030502@shatow.net> <1A22DCEC-9548-4FD2-BFC5-4F3F4EC1E1C2@gmail.com> <20130523075627.GA79696@FreeBSD.org> <519E0912.4070500@FreeBSD.org> <20130523130041.GA47068@FreeBSD.org> In-Reply-To: <20130523130041.GA47068@FreeBSD.org> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2SNWXUGQIVQDTTNXOBNAW" Cc: Martin Wilke , Chris Rees , Ports Management Team , FreeBSD Ports , Eitan Adler , Olivier Smedts , Martin Wilke , Bryan Drewery X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 May 2013 14:14:24 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2SNWXUGQIVQDTTNXOBNAW Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 5/23/2013 8:00 AM, Alexey Dokuchaev wrote: > On Thu, May 23, 2013 at 07:18:26AM -0500, Bryan Drewery wrote: >> On 5/23/2013 2:56 AM, Alexey Dokuchaev wrote: >>> FORCE_MAKE_JOBS is removed because it is the default. While here, I'= ve >>> moved empty(MAKE_JOBS_NUMBER) check higher, IMHO where it should belo= ng, >>> also saves a few lines. Reviews are welcome. >> >> Moving MAKE_JOBS_NUMBER is wrong, see r317639 >=20 > Hmm, can you explain a bit more? Maybe I am missing something here, bu= t > as I read log for r317639: >=20 > "[F]ix MAKE_JOBS_NUMBER not being set if none of DISABLE_MAKE_JOBS or= > MAKE_JOBS_UNSAFE or MAKE_JOBS_SAFE or FORCE_MAKE_JOBS were set." >=20 > Previously (without my patch) it could happen because of nested .if's. = Now > _MAKE_JOBS is set in both branches (true and false). Simple test on a = port > that does not set any MAKE_JOBS_* stuff, e.g. games/qcc: >=20 > $ make -V MAKE_JOBS_NUMBER > `/sbin/sysctl -n kern.smp.cpus` > $ make -V MAKE_JOBS_NUMBER -DDISABLE_MAKE_JOBS > 1 > $ make -V MAKE_JOBS_NUMBER -DMAKE_JOBS_UNSAFE > 1 > $ make -V MAKE_JOBS_NUMBER -DMAKE_JOBS_SAFE > `/sbin/sysctl -n kern.smp.cpus` > $ make -V MAKE_JOBS_NUMBER -DFORCE_MAKE_JOBS > `/sbin/sysctl -n kern.smp.cpus` >=20 > Can you show how can I get undefined _MAKE_JOBS? >=20 > ./danfe >=20 I see now. You removed this -.if defined(MAKE_JOBS_SAFE) || defined(FORCE_MAKE_JOBS) So it should be fine now. --=20 Regards, Bryan Drewery ------enig2SNWXUGQIVQDTTNXOBNAW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRniQ9AAoJEG54KsA8mwz5OlIQAIBI5NUR/z66vp66uqRX9Z3/ Ne2rCAae59VLSRQdkeRJ6A5cg+CMr5P6xegDG9klShBLCyeQQ2nHpcUKg8nPl8b5 fH/PMN3ddnTi/fW/hzf2fBBb2kDM/xk9XCFV1eeFUcXdBDq43qd9zIIYvjux+Bpb KNYg+lFya2D+0nRDsvTgb5gPeJyn5aFcP2+NecAmxxwUeksLLWYG/AijtUZgJ2Xa CXa7DxC3s97JtGuW22U+3HocHT73F9/O5HkwCarTluOlNgW4aBfv68sETHCC5IGS TGD1aN+zh7ScMTyPjF+WSSg7s3lUA6G5jTrzbafAmU6yXoGDsRkOLYE/pGxuUcBH fRaeQXycQn5YVdFKlskwGk907CBaI6gSs0fpdO3Z7e1tHCsW1zNwVUr7fWKuyrtZ 1tdAoFZdUH/p0HEMPFGpN/sZr6+CE550h2jdZY9DsukwEPoADOdTSO76dXwRKAUE jioVIPpMsttOltD7GSFdSR6RFO7CYTzDJKCSnDDro+ExkS/Au2c3Ma73zNr1SVXX GEzstlrfr55ZJ+1nmPFpAfNtIufZubNryNo3IBZ9+vhRhqDnVflmAcTieTiMOk+L VG1n7uaL/DXN0JUj69NfQ2X+vKG1vchpstNpxlWBsTuPWvTN4aLcNbGNWEinuXOn kmyTu7ZF+pThjFQkCtjh =ZGHv -----END PGP SIGNATURE----- ------enig2SNWXUGQIVQDTTNXOBNAW--